Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1465533004: Remove Nikita from OWNERS files. (Closed)

Created:
5 years, 1 month ago by achuithb
Modified:
4 years, 8 months ago
CC:
achuith+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dbeam+watch-options_chromium.org, dzhioev+watch_chromium.org, kalyank, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Nikita from OWNERS files. Also remove antrim@, merkulova@. Make OWNERS alphabetical. BUG= Committed: https://crrev.com/505c60a7a11bfdc5e9a11dfbfcede23a15a5a511 Cr-Commit-Position: refs/heads/master@{#389202}

Patch Set 1 #

Total comments: 2

Patch Set 2 : c/b/cros #

Patch Set 3 : missed one #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -61 lines) Patch
M ash/desktop_background/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/OWNERS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/background/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/OWNERS View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/reset/OWNERS View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/OWNERS View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/OWNERS View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/gaia_auth/OWNERS View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/help_app/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/OWNERS View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/OWNERS View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/OWNERS View 1 chunk +3 lines, -4 lines 0 comments Download
M components/about_ui/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/login/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download
M components/resources/OWNERS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/session_manager/OWNERS View 1 chunk +2 lines, -3 lines 0 comments Download
M components/user_manager/OWNERS View 1 chunk +2 lines, -3 lines 0 comments Download
M components/version_ui/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/OWNERS View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/webui/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (15 generated)
achuithb
Hopefully you won't receive owner lgtm requests after this
5 years, 1 month ago (2015-11-19 23:20:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465533004/1
5 years, 1 month ago (2015-11-19 23:23:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/125702) mac_chromium_gn_rel on ...
5 years, 1 month ago (2015-11-19 23:31:14 UTC) #6
Nikita (slow)
https://codereview.chromium.org/1465533004/diff/1/chrome/browser/chromeos/OWNERS File chrome/browser/chromeos/OWNERS (left): https://codereview.chromium.org/1465533004/diff/1/chrome/browser/chromeos/OWNERS#oldcode3 chrome/browser/chromeos/OWNERS:3: nkostylev@chromium.org Please leave this one.
4 years, 8 months ago (2016-04-04 14:52:26 UTC) #7
achuithb
I'm happy to leave you in some of the other OWNERs files - let me ...
4 years, 8 months ago (2016-04-04 21:54:10 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465533004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465533004/40001
4 years, 8 months ago (2016-04-04 21:54:48 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 22:48:58 UTC) #12
Nikita (slow)
lgtm
4 years, 8 months ago (2016-04-21 14:41:47 UTC) #13
achuithb
On 2016/04/21 14:41:47, Nikita (slow) wrote: > lgtm ty
4 years, 8 months ago (2016-04-21 17:27:51 UTC) #14
achuithb
jochen@chromium.org: Please review changes in chrome/OWNERS chrome/browser/OWNERS components/resources/OWNERS
4 years, 8 months ago (2016-04-21 17:33:41 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465533004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465533004/80001
4 years, 8 months ago (2016-04-21 17:38:13 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 18:27:42 UTC) #24
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-22 15:24:16 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465533004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465533004/80001
4 years, 8 months ago (2016-04-22 18:21:51 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-22 19:13:46 UTC) #29
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:51:26 UTC) #31
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/505c60a7a11bfdc5e9a11dfbfcede23a15a5a511
Cr-Commit-Position: refs/heads/master@{#389202}

Powered by Google App Engine
This is Rietveld 408576698