Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1465513002: [ios] Removed CRLSets usage for WKWebView. (Closed)

Created:
5 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
5 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed CRLSets usage for WKWebView. SecTrust API is used to make load/no-load decision for certs, while CertVerifier is used to get rejection reason. Using CRLSets to get rejection reason is impractical, because iOS blacklist is very different from Chrome blacklist as well as cost to store CRLSets on disk is very high. BUG=None Committed: https://crrev.com/c8fa67cfb0a220dc259cd433c2f5496b6fb80cbc Cr-Commit-Position: refs/heads/master@{#361212}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/web/net/crw_cert_verification_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Eugene But (OOO till 7-30)
I see your OOO (no review status), but this CL can sit here for a ...
5 years, 1 month ago (2015-11-19 17:18:51 UTC) #3
Ryan Sleevi
Reworded description to say CRLSets and not CLRSet. LGTM with nit. https://codereview.chromium.org/1465513002/diff/1/ios/web/net/crw_cert_verification_controller.mm File ios/web/net/crw_cert_verification_controller.mm (right): ...
5 years, 1 month ago (2015-11-23 22:26:12 UTC) #5
Eugene But (OOO till 7-30)
https://codereview.chromium.org/1465513002/diff/1/ios/web/net/crw_cert_verification_controller.mm File ios/web/net/crw_cert_verification_controller.mm (right): https://codereview.chromium.org/1465513002/diff/1/ios/web/net/crw_cert_verification_controller.mm#newcode434 ios/web/net/crw_cert_verification_controller.mm:434: // of low benefits and high cost of storing ...
5 years, 1 month ago (2015-11-23 22:36:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465513002/20001
5 years, 1 month ago (2015-11-23 22:36:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 23:12:37 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 23:14:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8fa67cfb0a220dc259cd433c2f5496b6fb80cbc
Cr-Commit-Position: refs/heads/master@{#361212}

Powered by Google App Engine
This is Rietveld 408576698