Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 14655012: SyncFS: Always normalize paths with FileSystemURL's ctor *and* GetNormalizedFilePath (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
Reviewers:
Gaurav, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

SyncFS: Always normalize paths with FileSystemURL's ctor *and* GetNormalizedFilePath BUG=238212 TEST=manual (launch chrome with --enable-sync-directory-operation, launch code-editor-app and see it doesn't crash on Windows) TBR=grv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kinuko
PTL
7 years, 7 months ago (2013-05-07 17:46:11 UTC) #1
Gaurav
On 2013/05/07 17:46:11, kinuko wrote: > PTL lgtp rubber-stamp
7 years, 7 months ago (2013-05-07 18:20:26 UTC) #2
Gaurav
On 2013/05/07 18:20:26, Gaurav wrote: > On 2013/05/07 17:46:11, kinuko wrote: > > PTL > ...
7 years, 7 months ago (2013-05-07 18:20:37 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 7 months ago (2013-05-07 18:35:14 UTC) #4
kinuko
TBR-ing tzik
7 years, 7 months ago (2013-05-07 18:36:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/14655012/1
7 years, 7 months ago (2013-05-07 18:36:44 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125131
7 years, 7 months ago (2013-05-07 19:10:00 UTC) #7
kinuko
Committed patchset #1 manually as r198784 (presubmit successful).
7 years, 7 months ago (2013-05-07 20:05:17 UTC) #8
tzik
7 years, 7 months ago (2013-05-08 03:29:18 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698