Client changes for disabled dasher account

sync/protocol/sync_protocol_error.h

Index: sync/protocol/sync_protocol_error.h
diff --git a/sync/protocol/sync_protocol_error.h b/sync/protocol/sync_protocol_error.h
index 8339d0322daf87971b57de9090eaf4c15d77249e..7b8d0bd9086d301733a7227df4bf363c2a543bcd 100644
--- a/sync/protocol/sync_protocol_error.h
+++ b/sync/protocol/sync_protocol_error.h
@@ -39,6 +39,9 @@ enum SyncProtocolErrorType {
   // Invalid Credential.
   INVALID_CREDENTIAL,
 
+  // An administrator disabled the account.

[Andrew T Wilson (Slow), 2013/05/13 11:51:13]

See my previous comment - I think "disabled the account" is a bit vague, since
the admin is really disabling the sync service on the domain, not actually
disabling the user acct.

[pavely, 2013/05/13 22:37:09]

Done.

+  DISABLED_BY_ADMIN,
+
   // The default value.
   UNKNOWN_ERROR
 };
@@ -59,6 +62,10 @@ enum ClientAction {
   // Wipe this client of any sync data.
   DISABLE_SYNC_ON_CLIENT,
 
+  // Account is disabled by admin. Stop sync, clear prefs and show message on
+  // settings page that account is disabled.
+  STOP_SYNC_FOR_DISABLED_ACCOUNT,

[tim (not reviewing), 2013/05/13 04:18:58]

Why is this here as a ClientAction? It isn't part of the actionable error proto
and I'm not sure it really fits, since it's a lot more specific than these...

[pavely, 2013/05/13 22:37:09]

I followed pattern of DISABLE_SYNC_ON_CLIENT. It is not really an action sent by
server but triggered by client based on server's error code. See
syncer_proto_util.cc: ConvertLegacyErrorCodeToNewError.
It is needed because error is detected on sync thread but action should be taken
on browser thread and ActionableError provides mechanism for it.

+
   // The default. No action.
   UNKNOWN_ACTION
 };