base/trace_event/trace_log.cc - Issue 1465433002: Remove ScopedVector from trace_log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_log.cc

Issue 1465433002: Remove ScopedVector from trace_log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add const Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_log.cc

diff --git a/base/trace_event/trace_log.cc b/base/trace_event/trace_log.cc

index c8b28e3878689e8d8ac4db99bdc25214222c3ca2..791d9a208b780b95c0dc12e0f67272679f9720ff 100644

--- a/base/trace_event/trace_log.cc

+++ b/base/trace_event/trace_log.cc

@@ -1530,7 +1530,7 @@ void TraceLog::AddMetadataEventsWhileLocked() {

lock_.AssertAcquired();

// Copy metadata added by |AddMetadataEvent| into the trace log.

- for (TraceEvent* event : metadata_events_)

+ for (const scoped_ptr<TraceEvent>& event : metadata_events_)

AddEventToThreadSharedChunkWhileLocked(nullptr, false)->CopyFrom(*event);

#if !defined(OS_NACL) // NaCl shouldn't expose the process id.

« no previous file with comments | « base/trace_event/trace_log.h ('k') | no next file » | no next file with comments »