Remove ScopedVector from trace_log

Remove ScopedVector from trace_log

BUG=554289
Committed: https://crrev.com/73be357897b5496f6bfa8d5ddefbccfca24b7c62
Cr-Commit-Position: refs/heads/master@{#361970}

[Olli Raula, 2015-11-19 16:04:53]

Description was changed from

==========
Remove ScopedVector from trace_log

BUG=554289
==========

to

==========
Remove ScopedVector from trace_log

BUG=554289
==========

[Olli Raula, 2015-11-19 16:04:53]

olli.raula@intel.com changed reviewers:
+ nduca@chromium.org

[Olli Raula, 2015-11-19 16:05:08]

Could you review

[Primiano Tucci (use gerrit), 2015-11-24 10:37:33]

I can take these reviews, just back from vacation.
I'm asking for clarifications on cxx@chromium.org, still not clear whether we
can use c++11 lib features in base/

See discussion in
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/gKRtFBugpeA

[Primiano Tucci (use gerrit), 2015-11-24 10:37:40]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Olli Raula, 2015-11-26 11:59:34]

Thanks for investicating, now looks like this is ok?

[Primiano Tucci (use gerrit), 2015-11-26 15:49:14]

LGTM with few nits

https://codereview.chromium.org/1465433002/diff/1/base/trace_event/trace_log.cc
File base/trace_event/trace_log.cc (right):

https://codereview.chromium.org/1465433002/diff/1/base/trace_event/trace_log....
base/trace_event/trace_log.cc:1532: for (scoped_ptr<TraceEvent>& event :
metadata_events_)
+const at this point?

https://codereview.chromium.org/1465433002/diff/1/base/trace_event/trace_log.h
File base/trace_event/trace_log.h (right):

https://codereview.chromium.org/1465433002/diff/1/base/trace_event/trace_log....
base/trace_event/trace_log.h:15: #include "base/memory/scoped_vector.h"
remove this line

[Olli Raula, 2015-11-27 08:35:13]

The CQ bit was checked by olli.raula@intel.com

[Olli Raula, 2015-11-27 08:35:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1465433002/#ps40001
(title: "Add const")

[commit-bot: I haz the power, 2015-11-27 08:35:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465433002/40001

[commit-bot: I haz the power, 2015-11-27 09:59:41]

Description was changed from

==========
Remove ScopedVector from trace_log

BUG=554289
==========

to

==========
Remove ScopedVector from trace_log

BUG=554289
==========

[commit-bot: I haz the power, 2015-11-27 09:59:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-27 10:00:21]

Description was changed from

==========
Remove ScopedVector from trace_log

BUG=554289
==========

to

==========
Remove ScopedVector from trace_log

BUG=554289

Committed: https://crrev.com/73be357897b5496f6bfa8d5ddefbccfca24b7c62
Cr-Commit-Position: refs/heads/master@{#361970}
==========

[commit-bot: I haz the power, 2015-11-27 10:00:22]

Patchset 3 (id:??) landed as
https://crrev.com/73be357897b5496f6bfa8d5ddefbccfca24b7c62
Cr-Commit-Position: refs/heads/master@{#361970}