Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: lib/src/runner/load_suite.dart

Issue 1465403002: Revert "Add RunnerSuite.{on,is}Debugging properties." (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/suite.dart ('k') | lib/src/runner/runner_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/load_suite.dart
diff --git a/lib/src/runner/load_suite.dart b/lib/src/runner/load_suite.dart
index 460e5e8857bc9b56408725f05618fd64ffcd7535..a83177746f0ddd81202ef33bd62b0a1d644e6c34 100644
--- a/lib/src/runner/load_suite.dart
+++ b/lib/src/runner/load_suite.dart
@@ -12,7 +12,6 @@ import '../../test.dart';
import '../backend/group.dart';
import '../backend/invoker.dart';
import '../backend/metadata.dart';
-import '../backend/suite.dart';
import '../backend/test.dart';
import '../backend/test_platform.dart';
import '../utils.dart';
@@ -34,11 +33,7 @@ import 'vm/environment.dart';
/// a normal test body, this logic isn't run until [LiveTest.run] is called. The
/// suite itself is returned by [suite] once it's avaialble, but any errors or
/// prints will be emitted through the running [LiveTest].
-class LoadSuite extends Suite implements RunnerSuite {
- final environment = const VMEnvironment();
- final isDebugging = false;
- final onDebugging = new StreamController<bool>().stream;
-
+class LoadSuite extends RunnerSuite {
/// A future that completes to the loaded suite once the suite's test has been
/// run and completed successfully.
///
@@ -113,7 +108,7 @@ class LoadSuite extends Suite implements RunnerSuite {
}
LoadSuite._(String name, void body(), this.suite, {TestPlatform platform})
- : super(new Group.root([
+ : super(const VMEnvironment(), new Group.root([
new LocalTest(name,
new Metadata(timeout: new Timeout(new Duration(minutes: 5))),
body)
@@ -121,7 +116,7 @@ class LoadSuite extends Suite implements RunnerSuite {
/// A constructor used by [changeSuite].
LoadSuite._changeSuite(LoadSuite old, Future<RunnerSuite> this.suite)
- : super(old.group, platform: old.platform);
+ : super(const VMEnvironment(), old.group, platform: old.platform);
/// Creates a new [LoadSuite] that's identical to this one, but that
/// transforms [suite] once it's loaded.
@@ -149,6 +144,4 @@ class LoadSuite extends Suite implements RunnerSuite {
await new Future.error(error.error, error.stackTrace);
throw 'unreachable';
}
-
- Future close() async {}
}
« no previous file with comments | « lib/src/runner/browser/suite.dart ('k') | lib/src/runner/runner_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698