LayoutTests/fast/canvas/script-tests/canvas-overloads-strokeRect.js - Issue 14654002: Make optional arguments in CanvasRenderingContext2D match the spec [1].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/script-tests/canvas-overloads-strokeRect.js

Issue 14654002: Make optional arguments in CanvasRenderingContext2D match the spec [1]. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Amend inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-overloads-strokeRect-expected.txt ('k') | LayoutTests/inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/canvas/script-tests/canvas-overloads-strokeRect.js

diff --git a/LayoutTests/fast/canvas/script-tests/canvas-overloads-strokeRect.js b/LayoutTests/fast/canvas/script-tests/canvas-overloads-strokeRect.js

index 3d6b18a1d502a347549cdb6cdb89d18765e58591..d7bbd7c63fdf6c75ee03f606823606971829b480 100644

--- a/LayoutTests/fast/canvas/script-tests/canvas-overloads-strokeRect.js

+++ b/LayoutTests/fast/canvas/script-tests/canvas-overloads-strokeRect.js

@@ -2,12 +2,11 @@ description("Test the behavior of CanvasRenderingContext2D.strokeRect() when cal

var ctx = document.createElement('canvas').getContext('2d');

-var SyntaxError = "SyntaxError: Syntax error";

-var TypeError = "TypeError: Type error";

+var TypeErrorNotEnoughArguments = "TypeError: Not enough arguments";

-shouldBe("ctx.strokeRect()", "undefined");

-shouldBe("ctx.strokeRect(0)", "undefined");

-shouldBe("ctx.strokeRect(0, 0)", "undefined");

-shouldBe("ctx.strokeRect(0, 0, 0)", "undefined");

+shouldThrow("ctx.strokeRect()", "TypeErrorNotEnoughArguments");

+shouldThrow("ctx.strokeRect(0)", "TypeErrorNotEnoughArguments");

+shouldThrow("ctx.strokeRect(0, 0)", "TypeErrorNotEnoughArguments");

+shouldThrow("ctx.strokeRect(0, 0, 0)", "TypeErrorNotEnoughArguments");

shouldBe("ctx.strokeRect(0, 0, 0, 0)", "undefined");

shouldBe("ctx.strokeRect(0, 0, 0, 0, 0)", "undefined");