[MD settings] small change to privacy page to better match UI mocks

[MD settings] small change to privacy page to better match UI mocks

This CL changes the buttons from being side-by-side (old style)
to being vertically listed (new mocks).

BUG=517564
Committed: https://crrev.com/2167f8b29d1dcfb83423f35d669ded4df955b8f0
Cr-Commit-Position: refs/heads/master@{#361403}

[dschuyler, 2015-11-24 00:49:59]

Description was changed from

==========
[MD settings] small change to privacy page to better match UI mocks

This CL changes the buttons from being side-by-side (old style)
to being vertically listed (new mocks).

BUG=517564
==========

to

==========
[MD settings] small change to privacy page to better match UI mocks

This CL changes the buttons from being side-by-side (old style)
to being vertically listed (new mocks).

BUG=517564
==========

[dschuyler, 2015-11-24 00:49:59]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2015-11-24 00:51:59]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org
- dpapad@chromium.org

[stevenjb, 2015-11-24 16:51:12]

https://codereview.chromium.org/1465393002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1465393002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:78: </div>
Is this a style that we will be using elsewhere? If so, would it be worth it to
make a single custom element that uses the same behaviors and applies the same
stylings in a single element?

I bring this up because, while this is only two elements, if we do it a lot it
does add up, and one of the things that came up repeatedly in the performance
meeting was number of DOM nodes.

[dschuyler, 2015-11-24 17:37:26]

https://codereview.chromium.org/1465393002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1465393002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:78: </div>
On 2015/11/24 16:51:12, stevenjb wrote:
> Is this a style that we will be using elsewhere? If so, would it be worth it
to
> make a single custom element that uses the same behaviors and applies the same
> stylings in a single element?
> 
> I bring this up because, while this is only two elements, if we do it a lot it
> does add up, and one of the things that came up repeatedly in the performance
> meeting was number of DOM nodes.

That makes sense.  I'll keep an eye out and add that on the third+ instance.  It

seems likely to happen.

[stevenjb, 2015-11-24 17:44:36]

On 2015/11/24 17:37:26, dschuyler wrote:
>
https://codereview.chromium.org/1465393002/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):
> 
>
https://codereview.chromium.org/1465393002/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/privacy_page/privacy_page.html:78: </div>
> On 2015/11/24 16:51:12, stevenjb wrote:
> > Is this a style that we will be using elsewhere? If so, would it be worth it
> to
> > make a single custom element that uses the same behaviors and applies the
same
> > stylings in a single element?
> > 
> > I bring this up because, while this is only two elements, if we do it a lot
it
> > does add up, and one of the things that came up repeatedly in the
performance
> > meeting was number of DOM nodes.
> 
> That makes sense.  I'll keep an eye out and add that on the third+ instance. 
It
> 
> seems likely to happen.

OK. lgtm.

[dschuyler, 2015-11-24 18:43:25]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2015-11-24 18:44:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465393002/1

[commit-bot: I haz the power, 2015-11-24 18:54:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-24 18:55:20]

Patchset 1 (id:??) landed as
https://crrev.com/2167f8b29d1dcfb83423f35d669ded4df955b8f0
Cr-Commit-Position: refs/heads/master@{#361403}