Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1465383006: Remove COMPILE_ASSERT macro from v8. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove COMPILE_ASSERT macro from v8. It appears unused, everything uses static_assert directly. BUG=none LOG=n Committed: https://crrev.com/eb536899b35cd2c6f01c50bfbe528a48dd11c3fa Cr-Commit-Position: refs/heads/master@{#32286}

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -62 lines) Patch
M src/base/macros.h View 1 2 chunks +2 lines, -62 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
5 years ago (2015-11-25 15:06:03 UTC) #2
jochen (gone - plz use gerrit)
the bots disagree however, a CL that updates COMPILE_ASSERT -> static_assert would be welcome :)
5 years ago (2015-11-25 15:09:02 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-25 15:12:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465383006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465383006/20001
5 years ago (2015-11-25 15:12:55 UTC) #6
Nico
Aha, looks like the reason this isn't used much in v8 is because you also ...
5 years ago (2015-11-25 15:19:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 16:03:18 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-25 16:03:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb536899b35cd2c6f01c50bfbe528a48dd11c3fa
Cr-Commit-Position: refs/heads/master@{#32286}

Powered by Google App Engine
This is Rietveld 408576698