[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml

Index: chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml
diff --git a/chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml b/chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml
new file mode 100644
index 0000000000000000000000000000000000000000..05435027b1aa63a0d44a2c211b539ad751e6b74e
--- /dev/null
+++ b/chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+<LinearLayout  xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
+    android:orientation="vertical">
+
+    <TextView
+        android:layout_height="wrap_content"
+        android:layout_width="match_parent"
+        android:paddingTop="7dip"
+        android:paddingBottom="7dip"
+        android:paddingStart="24dip"
+        android:paddingEnd="15dip"
+        style="@style/PreferenceTextAppearanceMedium"
+        android:text="@string/clear_browsing_data_important_dialog_text"/>
+
+    <ListView xmlns:android="http://schemas.android.com/apk/res/android"

[Theresa, 2016/05/26 23:21:56]

nit: remove the xmlns

[dmurph, 2016/05/27 02:09:12]

Done.

+        android:id="@id/select_dialog_listview"
+        android:layout_width="match_parent"
+        android:layout_height="0dp"
+        android:layout_weight="1"
+        android:divider="?android:attr/listDividerAlertDialog"
+        android:scrollbars="vertical"

[Theresa, 2016/05/26 23:44:49]

I think this is the default and can be removed. Also, when I was playing around
with this scrollIndicators didn't seem to have an effect (does it for you?) but
setting android:fadeScrollbars="false" kept the scrollbar always visible (I'm
assuming that's the goal).

[dmurph, 2016/05/27 02:09:12]

Done.

+        android:textAlignment="viewStart"

[Theresa, 2016/05/26 23:44:49]

Also, I think this is the default and can be removed and you may be able to
remove android:scrollbars="vertical" as well (it should show up automatically).

When I was playing around with this scrollIndicators didn't seem to have an
effect (does it for you?) but setting android:fadeScrollbars="false" kept the
scrollbar always visible (I'm assuming that's the goal).

[dmurph, 2016/05/27 02:09:12]

Done.

+        android:scrollIndicators="top|bottom" />
+</LinearLayout>
+

[Theresa, 2016/05/26 23:21:56]

unnecessary blank line.

I found this and some whitespace problems when applying your patch. It should be
easy to see the trailing whitespace issues with git show.

[dmurph, 2016/05/27 02:09:12]

Done.