Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Dialog layout change to make message always appear, and comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml
diff --git a/chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml b/chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml
new file mode 100644
index 0000000000000000000000000000000000000000..fc5220cd1f8c475262088b197503589087dd6135
--- /dev/null
+++ b/chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:orientation="vertical">
+
+ <TextView
+ android:layout_height="wrap_content"
+ android:layout_width="match_parent"
+ android:paddingTop="7dip"
Theresa 2016/05/26 18:08:45 dp
dmurph 2016/05/27 02:09:12 Done.
+ android:paddingBottom="7dip"
+ android:paddingStart="24dip"
+ android:paddingEnd="15dip"
+ style="?android:attr/textAppearanceMedium"
+ android:text="@string/clear_browsing_data_important_dialog_text"/>
+
+ <ListView xmlns:android="http://schemas.android.com/apk/res/android"
+ android:id="@id/select_dialog_listview"
+ android:layout_width="match_parent"
+ android:layout_height="0dp"
+ android:layout_weight="1"
+ android:divider="?android:attr/listDividerAlertDialog"
+ android:scrollbars="vertical"
+ android:textAlignment="viewStart"
+ android:scrollIndicators="top|bottom" />
Theresa 2016/05/26 18:08:45 Does only the ListView scroll now? What happens if
Theresa 2016/05/26 23:21:56 Per offline-discussion, add a TODO note to handle
dmurph 2016/05/27 02:09:12 Done.
+</LinearLayout>
+

Powered by Google App Engine
This is Rietveld 408576698