[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

components/browsing_data/storage_partition_http_cache_data_remover.cc

Index: components/browsing_data/storage_partition_http_cache_data_remover.cc
diff --git a/components/browsing_data/storage_partition_http_cache_data_remover.cc b/components/browsing_data/storage_partition_http_cache_data_remover.cc
index 773718db66ecd89f87ff57445986d3346760413c..03c0bcf0464917e1ecb35e02d4eac6375098873e 100644
--- a/components/browsing_data/storage_partition_http_cache_data_remover.cc
+++ b/components/browsing_data/storage_partition_http_cache_data_remover.cc
@@ -187,6 +187,7 @@ void StoragePartitionHttpCacheDataRemover::DoClearCache(int rv) {
                         base::Bind(
                             &StoragePartitionHttpCacheDataRemover::DoClearCache,
                             base::Unretained(this)));
+            rv = net::ERR_IO_PENDING;

[msramek, 2016/05/17 14:02:24]

Thanks for fixing this! But it should be:

rv = (new ConditionalCache...)->DeleteAndDestroySelfWhenFinished(...).

It is true that |DeleteAndDestroySelfWhenFinished| currently only returns
net::ERR_IO_PENDING, but it could conceivably return any other net error code.

[dmurph, 2016/05/18 23:28:00]

Done.

           } else if (delete_begin_.is_null() && delete_end_.is_max()) {
             rv = cache_->DoomAllEntries(base::Bind(
                 &StoragePartitionHttpCacheDataRemover::DoClearCache,