[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/confirm_important_sites_list_row.xml

Index: chrome/android/java/res/layout/confirm_important_sites_list_row.xml
diff --git a/chrome/android/java/res/layout/confirm_important_sites_list_row.xml b/chrome/android/java/res/layout/confirm_important_sites_list_row.xml
new file mode 100644
index 0000000000000000000000000000000000000000..75014ae9e0aa8a75b8685914643402bfe6a3b65e
--- /dev/null
+++ b/chrome/android/java/res/layout/confirm_important_sites_list_row.xml
@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<LinearLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:orientation="horizontal"
+    android:minHeight="?attr/listPreferredItemHeightSmall" 
+    android:padding="5dp">
+    <CheckBox
+        android:id="@+id/icon_row_checkbox"
+        android:clickable="false"
+        android:focusable="false"
+        android:focusableInTouchMode="false"
+        android:layout_width="0dp"
+        android:layout_weight="1"
+        android:layout_height="match_parent"
+        android:textAppearance="?android:attr/textAppearanceMedium"
+        android:gravity="center_vertical"
+        android:textColor="?attr/textColorAlertDialogListItem"/>
+    <ImageView
+        android:id="@+id/icon_row_image"
+        android:layout_width="16dip"

[Theresa, 2016/05/16 23:45:09]

nit: 16dp.

Let's set the height to 16dp too.

[dmurph, 2016/05/18 23:28:00]

This makes our icon appear in the top, instead of centered. Not sure why.

[Theresa, 2016/05/19 18:31:52]

Hm. I would have thought the scaleType and gravity positioned it correctly
(maybe it needs to be gravity="center"?), but if not then it's fine as is.

+        android:layout_height="match_parent"
+        android:gravity="center_vertical"
+        android:scaleType="center"
+        android:padding="5dp" />
+</LinearLayout>