chrome/browser/browsing_data/registrable_domain_filter_builder.cc - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/registrable_domain_filter_builder.cc

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments, test split up, cleanup Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/preferences/pref_service_bridge.cc ('K') | « chrome/browser/android/preferences/website_preference_bridge.cc ('k') | chrome/test/data/android/storage_persistance.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/registrable_domain_filter_builder.cc

diff --git a/chrome/browser/browsing_data/registrable_domain_filter_builder.cc b/chrome/browser/browsing_data/registrable_domain_filter_builder.cc

index 78fe5b41ffef51dcd633c27bc8ee124445171337..9480bc8420d7bc497365026e3319584cfb044201 100644

--- a/chrome/browser/browsing_data/registrable_domain_filter_builder.cc

+++ b/chrome/browser/browsing_data/registrable_domain_filter_builder.cc

@@ -99,6 +99,10 @@ bool RegistrableDomainFilterBuilder::MatchesURL(

const GURL& url) {

std::string url_registerable_domain =

GetDomainAndRegistry(url, INCLUDE_PRIVATE_REGISTRIES);

+ for (const auto& domain : *registerable_domains) {

Theresa 2016/05/16 22:37:08 Why is it an error to have registerable_domains?

dmurph 2016/05/16 23:00:18 Whoops, forgot to remove.

+ LOG(ERROR) << domain;

+ }

return (registerable_domains->find(url_registerable_domain) !=

registerable_domains->end() ||

(url.HostIsIPAddress() && (registerable_domains->find(url.host()) !=