components/browsing_data/storage_partition_http_cache_data_remover.cc - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browsing_data/storage_partition_http_cache_data_remover.cc

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whoops, forgot files Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/browsing_data/storage_partition_http_cache_data_remover.cc

diff --git a/components/browsing_data/storage_partition_http_cache_data_remover.cc b/components/browsing_data/storage_partition_http_cache_data_remover.cc

index 773718db66ecd89f87ff57445986d3346760413c..03c0bcf0464917e1ecb35e02d4eac6375098873e 100644

--- a/components/browsing_data/storage_partition_http_cache_data_remover.cc

+++ b/components/browsing_data/storage_partition_http_cache_data_remover.cc

@@ -187,6 +187,7 @@ void StoragePartitionHttpCacheDataRemover::DoClearCache(int rv) {

base::Bind(

&StoragePartitionHttpCacheDataRemover::DoClearCache,

base::Unretained(this)));

+ rv = net::ERR_IO_PENDING;

Theresa 2016/05/13 06:02:31 Why is this an error now?

dmurph 2016/05/13 23:46:24 Not really an error. This was missing from Martin'

} else if (delete_begin_.is_null() && delete_end_.is_max()) {

rv = cache_->DoomAllEntries(base::Bind(

&StoragePartitionHttpCacheDataRemover::DoClearCache,

« chrome/browser/android/preferences/website_preference_bridge.cc ('K') | « chrome/test/data/android/localstorage.html ('k') | no next file » | no next file with comments »