[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/manage_space_activity.xml

Index: chrome/android/java/res/layout/manage_space_activity.xml
diff --git a/chrome/android/java/res/layout/manage_space_activity.xml b/chrome/android/java/res/layout/manage_space_activity.xml
new file mode 100644
index 0000000000000000000000000000000000000000..82fe9afe0e6f274f1b95b5f44815ceff457960ec
--- /dev/null
+++ b/chrome/android/java/res/layout/manage_space_activity.xml
@@ -0,0 +1,121 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<ScrollView
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/main_scroll_view"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent" >
+
+    <LinearLayout
+        android:id="@+id/main_view"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:layout_marginStart="16dp"
+        android:layout_marginEnd="16dp"
+        android:orientation="vertical"
+        android:paddingStart="6dp"
+        android:paddingEnd="6dp"
+        android:paddingTop="5dp"
+        android:paddingBottom="5dp">
+
+        <!-- ======== 'Unimportant Storage' Info ======== -->
+        <TextView
+            android:id="@+id/unimportant_site_data_description"
+            android:text="@string/storage_management_unimportant_site_data_descriptive_text"
+            style="@style/ManageSpaceActivityExplanationTextView" />
+
+        <LinearLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:orientation="horizontal"
+            android:baselineAligned="true"
+            android:paddingTop="-1dp">

[Theresa, 2016/05/03 00:04:27]

I'm still not a fan of the negative top padding. How does this look with out it?
Are the designers okay with leaving it out?

[dmurph, 2016/05/04 00:51:00]

Whoops, I thought I removed this. My bad.

+
+            <TextView
+                android:id="@+id/unimportant_site_data_size_prefix"
+                android:text="@string/storage_management_unimportant_site_data_size_label"
+                style="@style/ManageSpaceActivitySizeTextView" />
+
+            <ImageView
+                android:src="@drawable/dotted_line_480px"

[Theresa, 2016/05/03 00:04:27]

This ImageView could use a declared style as well. Or a separate layout that can
be used with <include> since it's the exact same ImageView is used 3 times.

http://developer.android.com/training/improving-layouts/reusing-layouts.html

[dmurph, 2016/05/04 00:51:00]

Done.

+                android:layout_width="0dp"
+                android:layout_weight="1"
+                android:layout_height="1dp"
+                android:layout_gravity="bottom"
+                android:layout_marginStart="1dp"
+                android:layout_marginEnd="1dp"
+                android:layout_marginBottom="4dp"
+                android:scaleType="center" />
+
+            <TextView
+                android:id="@+id/unimportant_site_data_storage_size_text"
+                style="@style/ManageSpaceActivitySizeTextView" />
+        </LinearLayout>
+
+        <Button
+            android:id="@+id/clear_unimportant_site_data_storage"
+            android:text="@string/storage_management_clear_unimportant_site_data_button"
+            style="@style/ManageSpaceActivityButton" />
+
+
+        <!-- ======== Site Storage Info ======== -->
+        <TextView
+            android:id="@+id/site_data_description"
+            android:text="@string/storage_management_site_data_descriptive_text"
+            style="@style/ManageSpaceActivityExplanationTextView" />
+
+        <LinearLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:orientation="horizontal"
+            android:baselineAligned="true">
+
+            <TextView
+                android:id="@+id/site_data_size_prefix"
+                android:text="@string/storage_management_site_data_size_label"
+                style="@style/ManageSpaceActivitySizeTextView" />
+
+            <ImageView
+                android:src="@drawable/dotted_line_480px"
+                android:layout_width="0dp"
+                android:layout_weight="1"
+                android:layout_height="1dp"
+                android:layout_gravity="bottom"
+                android:layout_marginStart="1dp"
+                android:layout_marginEnd="1dp"
+                android:layout_marginBottom="4dp"
+                android:scaleType="center" />
+
+            <TextView
+                android:id="@+id/site_data_storage_size_text"
+                style="@style/ManageSpaceActivitySizeTextView" />
+        </LinearLayout>
+
+        <Button
+            android:id="@+id/manage_site_data_storage"
+            android:text="@string/storage_management_manage_site_data_button"
+                style="@style/ManageSpaceActivityButton" />
+
+        <!-- ======== Global storage info ======== -->
+        <LinearLayout
+            android:id="@+id/clear_all_data_section"
+            android:orientation="vertical"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content" 
+            android:paddingTop="12dp">
+
+            <TextView
+                android:id="@+id/all_storage_description"
+                android:text="@string/storage_management_all_storage_descriptive_text"
+                style="@style/ManageSpaceActivityExplanationTextView" />
+
+            <Button
+                android:id="@+id/clear_all_data"
+                android:text="@string/storage_management_clear_all_data_button"
+                style="@style/ManageSpaceActivityButton" />
+        </LinearLayout>
+    </LinearLayout>
+</ScrollView>