[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

content/public/android/java/strings/android_content_strings.grd

Index: content/public/android/java/strings/android_content_strings.grd
diff --git a/content/public/android/java/strings/android_content_strings.grd b/content/public/android/java/strings/android_content_strings.grd
index 5a1f7d4c6a8626a945ced44018d4d9537d25b387..e684152bd130ce77fcef9ce87a7e536ab1426616 100644
--- a/content/public/android/java/strings/android_content_strings.grd
+++ b/content/public/android/java/strings/android_content_strings.grd
@@ -93,6 +93,27 @@
   </translations>
   <release allow_pseudo="false" seq="1">
     <messages fallback_to_english="true">
+      <message name="IDS_STORAGE_CLEAR_BUTTON_TITLE" desc="Title of a button in the storage UI used to clear all storage data. [CHAR-LIMIT=24]">
+        Clear
+      </message>
+      <message name="IDS_STORAGE_CLEAR_DIALOG_TITLE" desc="Title of the clear storage dialog in the storage UI used to clear all site storage data. [CHAR-LIMIT=24]">
+        Clear site storage
+      </message>
+      <message name="IDS_STORAGE_CLEAR_DIALOG_TEXT" desc="Text of the clear storage dialog which give the user a choice to reset the app or delete site storage data.">
+        This will clear <ph name="SIZE_IN_KB">%1$s<ex>101kb</ex></ph> of storage from sites not marked as important. To clear all app storage, reset Chrome to its factory default.

[newt (away), 2015/11/25 15:56:25]

What does "marked as important" mean? Do we expect users to know what this
means? (We shouldn't; I don't know what this means)

If this simply means sites that are saved offline, or some other
simple-to-enumerate category, I think it would be more useful to call it out
specifically.

[dmurph, 2015/11/25 23:47:46]

Whoops, this is a fragment from the future! Changed to be the current meaning.

+      </message>

[Finnur, 2015/11/25 11:30:22]

Is this a dialog with two destructive actions and no cancel button?

[dmurph, 2015/11/25 23:47:46]

I use the R.id.cancel resource. Is that alright?

+      <message name="IDS_STORAGE_CLEAR_DIALOG_RESET_APP_OPTION" desc="">

[newt (away), 2015/11/25 15:56:25]

needs a description; same below

[dmurph, 2015/11/25 23:47:46]

Done.

+        Reset App

[newt (away), 2015/11/25 15:56:25]

Use "Sentence case", i.e. only capitalize the first word of each title. This is
the convention used throughout Android UI.

[dmurph, 2015/11/25 23:47:46]

For buttons? ok.

[newt (away), 2015/12/09 01:00:44]

Yes, sentence case for everything on Android. (except sometimes chrome:// pages,
where we're lazy and use the same string across all platforms)

+      </message>
+      <message name="IDS_STORAGE_CLEAR_DIALOG_CLEAR_STORAGE_OPTION" desc="">
+        Clear Site Storage

[newt (away), 2015/11/25 15:56:25]

sentence case

[dmurph, 2015/11/25 23:47:46]

Done.

+      </message>
+      <message name="IDS_STORAGE_RESET_APP_DIALOG_TITLE" desc="Title of the reset app dialog in the storage UI used to reset the app. [CHAR-LIMIT=24]">
+        Delete app data?
+      </message>
+      <message name="IDS_STORAGE_RESET_APP_DIALOG_TEXT" desc="Text of the reset app dialoag in the storage UI.">
+        All this app's data will be deleted permanently. This includes all files, settings, accounts, databases, etc.

[Finnur, 2015/11/25 11:30:22]

'This app' seems a bit generic. Is that the string you were requested to use?

[dmurph, 2015/11/25 23:47:46]

I just copied it from the mocks. Changed to Chrome.

+      </message>

[Finnur, 2015/11/25 11:30:22]

This is not the file I would have expected to see these strings in... Why pick
this over android_chrome_strings.grd, for example?

Also, this file seems ordered alphabetically, except for these new strings.

[newt (away), 2015/11/25 15:56:25]

Right, these strings should be in android_chrome_strings.grd, since they're used
only in src/chrome/android code. Please group them with relevant strings in
android_chrome_strings.grd

[dmurph, 2015/11/25 23:47:46]

Done.

       <message name="IDS_ACTIONBAR_SHARE" desc="Contextual action bar item for sharing a block of text via email, or other method. [CHAR-LIMIT=24]">
         Share
       </message>