[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/storage_preference_fragment.xml

Index: chrome/android/java/res/layout/storage_preference_fragment.xml
diff --git a/chrome/android/java/res/layout/storage_preference_fragment.xml b/chrome/android/java/res/layout/storage_preference_fragment.xml
new file mode 100644
index 0000000000000000000000000000000000000000..a4d1e62ed2d3bedb956dd55d55e0653fb08fe8f9
--- /dev/null
+++ b/chrome/android/java/res/layout/storage_preference_fragment.xml
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="utf-8"?>

[Finnur, 2015/11/24 16:39:53]

Would be good to get a screenshot of this UI.

[dmurph, 2015/11/25 23:47:45]

Put screenshot in bug.

+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<!-- Based on Android framework file, with customization to keep button bar
+     visible:
+     platform_frameworks_base/core/res/res/layout/preference_list_fragment.xml
+     -->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

[newt (away), 2015/11/25 15:56:25]

standard indentation for Android xml files looks like this:

    <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
        android:orientation="vertical"
        ... />

        <FrameLayout
            android:layout_width="match_parent"
            ... />

            <ListView android:id="@android:id/list" ... />

        </FrameLayout>

    </LinearLayout>

[dmurph, 2015/11/25 23:47:46]

So this means I'm adding a couple of newlines, right?

+    android:orientation="vertical"
+    android:layout_height="match_parent"
+    android:layout_width="match_parent"
+    android:background="@android:color/transparent">
+
+  <FrameLayout
+      android:layout_width="match_parent"
+      android:layout_height="0dp"

[Finnur, 2015/11/25 11:30:22]

Unites are irrelevant with 0, just use "0", same with below.

[newt (away), 2015/11/25 15:56:25]

Actually, you need units even when the value is 0 (unlike CSS)

[Finnur, 2015/11/26 15:54:41]

I've been working too much in Polymer lately. :)

+      android:layout_weight="1"

[Finnur, 2015/11/25 11:30:22]

But don't you want the unit here?

[newt (away), 2015/11/25 15:56:25]

layout_weight doesn't actually have units

[Finnur, 2015/11/26 15:54:41]

Oh. I mistook weight for width. Sorry. :)

+      android:background="@android:color/transparent">
+
+      <ListView android:id="@android:id/list"
+          android:layout_width="match_parent"
+          android:layout_height="match_parent"
+          android:paddingTop="0dip"
+          android:paddingBottom="0dp"
+          android:clipToPadding="false"
+          android:drawSelectorOnTop="false"
+          android:cacheColorHint="@android:color/transparent"
+          android:scrollbarAlwaysDrawVerticalTrack="true" />
+  
+      <TextView android:id="@android:id/empty"
+          android:layout_width="match_parent"
+          android:layout_height="match_parent"
+          android:padding="8dip"
+          android:textAppearance="?android:attr/textAppearanceMedium"
+          android:gravity="center"
+          android:visibility="gone" />
+    </FrameLayout>
+
+    <RelativeLayout android:id="@+id/button_bar"
+        android:layout_height="wrap_content"
+        android:layout_width="match_parent"
+        android:layout_weight="0">
+
+        <Button android:id="@+id/clear_button"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_margin="5dip"
+            android:layout_weight="1"
+            android:text="@string/storage_clear_button_title"
+        />
+    </RelativeLayout>
+</LinearLayout>