chrome/android/java/res/layout/storage_preference_fragment.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff: chrome/android/java/res/layout/storage_preference_fragment.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile & comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/manage_space_activity.xml ('K') | « chrome/android/java/res/layout/manage_space_activity.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Ted C 2016/06/06 23:53:55 storage_preference_fragment doesn't seem to be con storage_preference_fragment doesn't seem to be consistent naming. the other case this is used is just website_preferences.xml. maybe this should be storage_preferences.xml or something. Mainly the _fragment bit seems unnecessary. dmurph 2016/06/07 17:57:01 Done. Show quoted text On 2016/06/06 at 23:53:55, Ted C wrote: > storage_preference_fragment doesn't seem to be consistent naming. > > the other case this is used is just website_preferences.xml. maybe this should be storage_preferences.xml or something. Mainly the _fragment bit seems unnecessary. Done.
	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:orientation="vertical"

	8 android:layout_height="match_parent"

	9 android:layout_width="match_parent"

	10 android:background="@android:color/transparent">
	Ted C 2016/06/06 23:53:54 why do you need to specify a background? could yo why do you need to specify a background? could you use @null if you must be clearing some default? dmurph 2016/06/07 17:57:01 This is from the default layout xml. I can remove. Show quoted text On 2016/06/06 at 23:53:54, Ted C wrote: > why do you need to specify a background? could you use @null if you must be clearing some default? This is from the default layout xml. I can remove.
	11

	12 <ListView android:id="@android:id/list"

	13 android:layout_width="match_parent"

	14 android:layout_height="0dp"

	15 android:layout_weight="1"

	16 android:paddingTop="0dp"
	Ted C 2016/06/06 23:53:54 shouldn't 0 be the default padding? why adding th shouldn't 0 be the default padding? why adding these? dmurph 2016/06/07 17:57:01 Copied this from the system layout file. Show quoted text On 2016/06/06 at 23:53:54, Ted C wrote: > shouldn't 0 be the default padding? why adding these? Copied this from the system layout file.
	17 android:paddingBottom="0dp"/>

	18

	19 <TextView android:id="@android:id/empty"
	Ted C 2016/06/06 23:53:54 do you actually need this? I don't see it set any do you actually need this? I don't see it set anywhere else and the text here is empty, so I don't know if it adds anything. dmurph 2016/06/07 17:57:01 Yes, when the list is empty we display this text. Show quoted text On 2016/06/06 at 23:53:54, Ted C wrote: > do you actually need this? I don't see it set anywhere else and the text here is empty, so I don't know if it adds anything. Yes, when the list is empty we display this text. We store it here: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
	20 android:layout_width="match_parent"

	21 android:layout_height="match_parent"

	22 android:padding="8dp"

	23 android:textAppearance="?android:attr/textAppearanceMedium"

	24 android:gravity="center"

	25 android:visibility="gone"/>

	26

	27 <Button android:id="@+id/clear_button"

	28 android:layout_width="match_parent"

	29 android:layout_height="wrap_content"

	30 android:text="@string/storage_clear_button_title"

	31 style="@style/FlushFooterButton"/>

	32 </LinearLayout>

OLD	NEW