Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/android/preferences/pref_service_bridge.h" | 5 #include "chrome/browser/android/preferences/pref_service_bridge.h" |
| 6 | 6 |
| 7 #include <jni.h> | 7 #include <jni.h> |
| 8 #include <stddef.h> | 8 #include <stddef.h> |
| 9 | 9 |
| 10 #include <memory> | 10 #include <memory> |
| (...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 643 } | 643 } |
| 644 | 644 |
| 645 static jboolean CanDeleteBrowsingHistory(JNIEnv* env, | 645 static jboolean CanDeleteBrowsingHistory(JNIEnv* env, |
| 646 const JavaParamRef<jobject>& obj) { | 646 const JavaParamRef<jobject>& obj) { |
| 647 return GetPrefService()->GetBoolean(prefs::kAllowDeletingBrowserHistory); | 647 return GetPrefService()->GetBoolean(prefs::kAllowDeletingBrowserHistory); |
| 648 } | 648 } |
| 649 | 649 |
| 650 static void FetchImportantSites(JNIEnv* env, | 650 static void FetchImportantSites(JNIEnv* env, |
| 651 const JavaParamRef<jclass>& clazz, | 651 const JavaParamRef<jclass>& clazz, |
| 652 const JavaParamRef<jobject>& java_callback) { | 652 const JavaParamRef<jobject>& java_callback) { |
| 653 std::vector<GURL> example_origins; | |
| 653 std::vector<std::string> important_domains = | 654 std::vector<std::string> important_domains = |
| 654 ImportantSitesUtil::GetImportantRegisterableDomains(GetOriginalProfile(), | 655 ImportantSitesUtil::GetImportantRegisterableDomains( |
| 655 kMaxImportantSites); | 656 GetOriginalProfile(), kMaxImportantSites, &example_origins); |
| 656 ScopedJavaLocalRef<jobjectArray> string_array = | 657 ScopedJavaLocalRef<jobjectArray> java_domains = |
| 657 base::android::ToJavaArrayOfStrings(env, important_domains); | 658 base::android::ToJavaArrayOfStrings(env, important_domains); |
| 659 | |
| 660 // We reuse the important domains vector to convert example origins to string. | |
|
Theresa
2016/05/25 18:14:27
nit: s/string/strings
dmurph
2016/05/25 20:32:23
done.
| |
| 661 important_domains.resize(example_origins.size()); | |
| 662 std::transform(example_origins.begin(), example_origins.end(), | |
| 663 important_domains.begin(), | |
| 664 [](const GURL& origin) { return origin.spec(); }); | |
| 665 ScopedJavaLocalRef<jobjectArray> java_origins = | |
| 666 base::android::ToJavaArrayOfStrings(env, important_domains); | |
| 667 | |
| 658 Java_ImportantSitesCallback_onImportantRegisterableDomainsReady( | 668 Java_ImportantSitesCallback_onImportantRegisterableDomainsReady( |
| 659 env, java_callback.obj(), string_array.obj()); | 669 env, java_callback.obj(), java_domains.obj(), java_origins.obj()); |
| 670 } | |
| 671 | |
| 672 static jint GetMaxImportantSites(JNIEnv* env, | |
| 673 const JavaParamRef<jclass>& clazz) { | |
| 674 return kMaxImportantSites; | |
| 675 } | |
| 676 | |
| 677 static void MarkOriginAsImportantForTesting( | |
| 678 JNIEnv* env, | |
| 679 const JavaParamRef<jclass>& clazz, | |
| 680 const JavaParamRef<jstring>& jorigin) { | |
| 681 GURL origin(base::android::ConvertJavaStringToUTF8(jorigin)); | |
| 682 CHECK(origin.is_valid()); | |
| 683 ImportantSitesUtil::MarkOriginAsImportantForTesting(GetOriginalProfile(), | |
| 684 origin); | |
| 660 } | 685 } |
| 661 | 686 |
| 662 static void ShowNoticeAboutOtherFormsOfBrowsingHistory( | 687 static void ShowNoticeAboutOtherFormsOfBrowsingHistory( |
| 663 ScopedJavaGlobalRef<jobject>* listener, | 688 ScopedJavaGlobalRef<jobject>* listener, |
| 664 bool show) { | 689 bool show) { |
| 665 JNIEnv* env = AttachCurrentThread(); | 690 JNIEnv* env = AttachCurrentThread(); |
| 666 UMA_HISTOGRAM_BOOLEAN( | 691 UMA_HISTOGRAM_BOOLEAN( |
| 667 "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated", show); | 692 "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated", show); |
| 668 if (!show) | 693 if (!show) |
| 669 return; | 694 return; |
| (...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1132 | 1157 |
| 1133 return ConvertJavaStringToUTF8(android_permission); | 1158 return ConvertJavaStringToUTF8(android_permission); |
| 1134 } | 1159 } |
| 1135 | 1160 |
| 1136 static void SetSupervisedUserId(JNIEnv* env, | 1161 static void SetSupervisedUserId(JNIEnv* env, |
| 1137 const JavaParamRef<jobject>& obj, | 1162 const JavaParamRef<jobject>& obj, |
| 1138 const JavaParamRef<jstring>& pref) { | 1163 const JavaParamRef<jstring>& pref) { |
| 1139 GetPrefService()->SetString(prefs::kSupervisedUserId, | 1164 GetPrefService()->SetString(prefs::kSupervisedUserId, |
| 1140 ConvertJavaStringToUTF8(env, pref)); | 1165 ConvertJavaStringToUTF8(env, pref)); |
| 1141 } | 1166 } |
| OLD | NEW |