chrome/android/java/res/drawable/flush_footer_button.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/flush_footer_button.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments, style fix, progress dialog change Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/res/layout/clear_browsing_important_dialog_listview.xml » ('j') | chrome/android/java/res/layout/confirm_important_sites_list_row.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <shape xmlns:android="http://schemas.android.com/apk/res/android"	6 <shape xmlns:android="http://schemas.android.com/apk/res/android"

7 android:shape="rectangle">	7 android:shape="rectangle">

8 <solid	8 <corners android:radius="0dp"/>
	Theresa 2016/05/19 18:31:52 Wouldn't corners with radius 0 just be a regular r Wouldn't corners with radius 0 just be a regular rectangle? What happens if you remove this line? dmurph 2016/05/19 22:41:50 ah, yeah, done. Show quoted text On 2016/05/19 at 18:31:52, Theresa Wellington wrote: > Wouldn't corners with radius 0 just be a regular rectangle? What happens if you remove this line? ah, yeah, done.
9 android:color="@color/snippets_separator" />	9 <solid android:color="@color/google_grey_100" />

10 <size	10 <stroke android:width="1dp" android:color="@color/google_grey_300"/>

11 android:height="@dimen/snippets_vertical_spacing" />

12 </shape>	11 </shape>

OLD	NEW