Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/preferences/pref_service_bridge.h" 5 #include "chrome/browser/android/preferences/pref_service_bridge.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 const JavaParamRef<jobject>& java_callback) { 652 const JavaParamRef<jobject>& java_callback) {
653 std::vector<std::string> important_domains = 653 std::vector<std::string> important_domains =
654 ImportantSitesUtil::GetImportantRegisterableDomains(GetOriginalProfile(), 654 ImportantSitesUtil::GetImportantRegisterableDomains(GetOriginalProfile(),
655 kMaxImportantSites); 655 kMaxImportantSites);
656 ScopedJavaLocalRef<jobjectArray> string_array = 656 ScopedJavaLocalRef<jobjectArray> string_array =
657 base::android::ToJavaArrayOfStrings(env, important_domains); 657 base::android::ToJavaArrayOfStrings(env, important_domains);
658 Java_ImportantSitesCallback_onImportantRegisterableDomainsReady( 658 Java_ImportantSitesCallback_onImportantRegisterableDomainsReady(
659 env, java_callback.obj(), string_array.obj()); 659 env, java_callback.obj(), string_array.obj());
660 } 660 }
661 661
662 static jint GetMaxImportantSites(JNIEnv* env,
663 const JavaParamRef<jclass>& clazz) {
664 return kMaxImportantSites;
665 }
666
667 static void MarkOriginAsImportantForTesting(
668 JNIEnv* env,
669 const JavaParamRef<jclass>& clazz,
670 const JavaParamRef<jstring>& jorigin) {
671 GURL origin(base::android::ConvertJavaStringToUTF8(jorigin));
672 CHECK(origin.is_valid());
673 ImportantSitesUtil::MarkOriginAsImportantForTesting(GetOriginalProfile(),
674 origin);
675 }
676
662 static void ShowNoticeAboutOtherFormsOfBrowsingHistory( 677 static void ShowNoticeAboutOtherFormsOfBrowsingHistory(
663 ScopedJavaGlobalRef<jobject>* listener, 678 ScopedJavaGlobalRef<jobject>* listener,
664 bool show) { 679 bool show) {
665 JNIEnv* env = AttachCurrentThread(); 680 JNIEnv* env = AttachCurrentThread();
666 UMA_HISTOGRAM_BOOLEAN( 681 UMA_HISTOGRAM_BOOLEAN(
667 "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated", show); 682 "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated", show);
668 if (!show) 683 if (!show)
669 return; 684 return;
670 Java_OtherFormsOfBrowsingHistoryListener_showNoticeAboutOtherFormsOfBrowsingHi story( 685 Java_OtherFormsOfBrowsingHistoryListener_showNoticeAboutOtherFormsOfBrowsingHi story(
671 env, listener->obj()); 686 env, listener->obj());
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1132 1147
1133 return ConvertJavaStringToUTF8(android_permission); 1148 return ConvertJavaStringToUTF8(android_permission);
1134 } 1149 }
1135 1150
1136 static void SetSupervisedUserId(JNIEnv* env, 1151 static void SetSupervisedUserId(JNIEnv* env,
1137 const JavaParamRef<jobject>& obj, 1152 const JavaParamRef<jobject>& obj,
1138 const JavaParamRef<jstring>& pref) { 1153 const JavaParamRef<jstring>& pref) {
1139 GetPrefService()->SetString(prefs::kSupervisedUserId, 1154 GetPrefService()->SetString(prefs::kSupervisedUserId,
1140 ConvertJavaStringToUTF8(env, pref)); 1155 ConvertJavaStringToUTF8(env, pref));
1141 } 1156 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698