chrome/android/java/res/layout/storage_preference_fragment.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/storage_preference_fragment.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whoops, forgot files Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/select_dialog_listview.xml ('K') | « chrome/android/java/res/layout/select_dialog_listview.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/res/values/values.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:orientation="vertical"

	8 android:layout_height="match_parent"

	9 android:layout_width="match_parent"

	10 android:background="@android:color/transparent">

	11

	12 <ListView android:id="@android:id/list"

	13 android:layout_width="match_parent"

	14 android:layout_height="0px"

	15 android:layout_weight="1"

	16 android:paddingTop="0dp"

	17 android:paddingBottom="0dp"

	18 android:clipToPadding="false"

	19 android:cacheColorHint="@android:color/transparent"/>

	20

	21 <TextView android:id="@android:id/empty"

	22 android:layout_width="match_parent"

	23 android:layout_height="match_parent"

	24 android:padding="8dp"

	25 android:textAppearance="?android:attr/textAppearanceMedium"

	26 android:gravity="center"

	27 android:visibility="gone"/>

	28

	29 <RelativeLayout android:id="@+id/button_bar"
	Theresa 2016/05/13 06:02:30 Can this be a FrameLayout instead of a RelativeLay Can this be a FrameLayout instead of a RelativeLayout since it only contains one thing? dmurph 2016/05/13 23:46:23 Done. Show quoted text On 2016/05/13 at 06:02:30, Theresa Wellington wrote: > Can this be a FrameLayout instead of a RelativeLayout since it only contains one thing? Done. Theresa 2016/05/14 00:05:38 On second thought - or just the child. Does it nee Show quoted text On 2016/05/13 23:46:23, dmurph wrote: > On 2016/05/13 at 06:02:30, Theresa Wellington wrote: > > Can this be a FrameLayout instead of a RelativeLayout since it only contains > one thing? > > Done. On second thought - or just the child. Does it need a viewgroup parent? dmurph 2016/05/16 22:38:25 Done. Show quoted text On 2016/05/14 at 00:05:38, Theresa Wellington wrote: > On 2016/05/13 23:46:23, dmurph wrote: > > On 2016/05/13 at 06:02:30, Theresa Wellington wrote: > > > Can this be a FrameLayout instead of a RelativeLayout since it only contains > > one thing? > > > > Done. > > On second thought - or just the child. Does it need a viewgroup parent? Done.
	30 android:layout_height="wrap_content"

	31 android:layout_width="match_parent"

	32 android:layout_weight="0">

	33

	34 <Button android:id="@+id/clear_button"

	35 android:layout_width="match_parent"

	36 android:layout_height="wrap_content"

	37 android:layout_margin="5dp"

	38 android:text="@string/storage_clear_button_title"/>

	39 </RelativeLayout>

	40 </LinearLayout>

OLD	NEW