chrome/android/java/res/layout/dotted_line_span.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/dotted_line_span.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: successful async startup. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxhdpi/dotted_line_480px.png ('k') | chrome/android/java/res/layout/manage_space_activity.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <merge xmlns:android="http://schemas.android.com/apk/res/android">

	7 <ImageView xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:src="@drawable/dotted_line_480px"
	Theresa 2016/05/04 22:24:00 We should drop the "480px" from the name. How big We should drop the "480px" from the name. How big are all of the png's for the dotted_line pngs combined? dmurph 2016/05/05 21:53:29 2kb Show quoted text On 2016/05/04 at 22:24:00, Theresa Wellington wrote: > We should drop the "480px" from the name. How big are all of the png's for the dotted_line pngs combined? 2kb Theresa 2016/05/06 17:05:19 sg. Earlier I had suggested looking at using tileM Show quoted text On 2016/05/05 21:53:29, dmurph wrote: > On 2016/05/04 at 22:24:00, Theresa Wellington wrote: > > We should drop the "480px" from the name. How big are all of the png's for the > dotted_line pngs combined? > > 2kb sg. Earlier I had suggested looking at using tileMode=repeat on a <bitmap> drawable, but I don't think 2kb is worth it.
	9 android:layout_width="0dp"

	10 android:layout_weight="1"

	11 android:layout_height="1dp"

	12 android:layout_gravity="bottom"

	13 android:layout_marginStart="1dp"

	14 android:layout_marginEnd="1dp"

	15 android:layout_marginBottom="4dp"

	16 android:scaleType="center" />

	17 </merge>

OLD	NEW