chrome/android/java/res/values/constants.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values/constants.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments, working Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/values-v19/constants.xml ('K') | « chrome/android/java/res/values-v19/constants.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5

6 <resources>	5 <resources>

7 <dimen name="toolbar_content_inset_start">80dp</dimen>	6 <!-- Our manage space activity. Default pre-KLP. -->
	Finnur 2016/04/27 13:49:15 I'm drawing a blank... KLP is what again? I'm drawing a blank... KLP is what again? dmurph 2016/04/27 20:36:47 Switched to KitKat ;) Show quoted text On 2016/04/27 at 13:49:15, Finnur wrote: > I'm drawing a blank... KLP is what again? Switched to KitKat ;) Theresa 2016/04/27 21:10:58 I think KitKat, since the activity is for API leve Show quoted text On 2016/04/27 13:49:15, Finnur wrote: > I'm drawing a blank... KLP is what again? I think KitKat, since the activity is for API level 19+. I would replace this string with pre-KitKat and expand this comment to include the info in the CL description about the API needed not being available pre-KitKat. I'm (pleasantly) surprised Android handles empty strings in the manifest correctly.
8 </resources>	7 <string name="manage_space_activity" translatable="false"></string>

	8 </resources>

OLD	NEW