Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: scripts/slave/recipe_modules/chromium_android/config.py

Issue 1465343002: [Android] Add context manager to record logcat during step(s). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Removed unused config. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/config.py
diff --git a/scripts/slave/recipe_modules/chromium_android/config.py b/scripts/slave/recipe_modules/chromium_android/config.py
index 875fe1daefac07f07840d14a8c6c421e8dc5e2a2..f42adc4b61f185e14fbb20ea75ee43d0a625a19e 100644
--- a/scripts/slave/recipe_modules/chromium_android/config.py
+++ b/scripts/slave/recipe_modules/chromium_android/config.py
@@ -29,6 +29,7 @@ def BaseConfig(INTERNAL=False, REPO_NAME=None, REPO_URL=None,
tests = List(inner_type=basestring),
cr_build_android = Static(Path('[CHECKOUT]', 'build', 'android')),
test_runner = Single(Path),
+ default_logcat_dir = Single(Path),
gclient_custom_deps = Dict(value_type=(basestring, types.NoneType)),
channel = Single(basestring, empty_val='chrome'),
gclient_custom_vars = Dict(value_type=(basestring, types.NoneType)),
@@ -46,6 +47,7 @@ config_ctx = config_item_context(BaseConfig)
@config_ctx(is_root=True)
def base_config(c):
+ c.default_logcat_dir = Path('[CHECKOUT]', 'out', 'logcat_dir')
c.internal_dir_name = 'clank'
c.test_runner = Path('[CHECKOUT]', 'build', 'android', 'test_runner.py')

Powered by Google App Engine
This is Rietveld 408576698