Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/android_webview_shell_tests.py

Issue 1465343002: [Android] Add context manager to record logcat during step(s). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/chromium_android/example.py ('K') | « scripts/slave/recipes/android_webview_cts_tests.expected/Test_parsing_report_xml_with_unexpected_method_failed.json ('k') | scripts/slave/recipes/android_webview_shell_tests.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/android_webview_shell_tests.py
diff --git a/scripts/slave/recipes/android_webview_shell_tests.py b/scripts/slave/recipes/android_webview_shell_tests.py
index 4c40c4a8f9a50aca92b0cc4615fa9c2eb4e18b6f..a1ff3e7700b99c42961da6fa1d0e78f1487be4cd 100644
--- a/scripts/slave/recipes/android_webview_shell_tests.py
+++ b/scripts/slave/recipes/android_webview_shell_tests.py
@@ -85,8 +85,9 @@ def RunSteps(api):
# Run the instrumentation tests from the package.
run_tests(api)
- api.chromium_android.logcat_dump()
- api.chromium_android.stack_tool_steps()
+ logcat_file = api.chromium.output_dir.join('full_logcat')
+ api.chromium_android.logcat_dump(output_logcat_file=logcat_file)
+ api.chromium_android.stack_tool_steps(logcat_file=logcat_file)
api.chromium_android.test_report()
def run_tests(api):
« scripts/slave/recipe_modules/chromium_android/example.py ('K') | « scripts/slave/recipes/android_webview_cts_tests.expected/Test_parsing_report_xml_with_unexpected_method_failed.json ('k') | scripts/slave/recipes/android_webview_shell_tests.expected/basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698