Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/android_webview_aosp_perf.py

Issue 1465343002: [Android] Add context manager to record logcat during step(s). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/chromium_android/example.py ('K') | « scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json ('k') | scripts/slave/recipes/android_webview_aosp_perf.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/android_webview_aosp_perf.py
diff --git a/scripts/slave/recipes/android_webview_aosp_perf.py b/scripts/slave/recipes/android_webview_aosp_perf.py
index ea3f152828330ad02c6d5f5d1848e51a8bddbc83..1476308de9a6958f770bacb765ce693dff366c4f 100644
--- a/scripts/slave/recipes/android_webview_aosp_perf.py
+++ b/scripts/slave/recipes/android_webview_aosp_perf.py
@@ -77,8 +77,9 @@ def RunSteps(api):
chartjson_file=True,
perf_id=BUILDER['perf_id'])
finally:
- api.chromium_android.logcat_dump()
- api.chromium_android.stack_tool_steps()
+ logcat_file = api.chromium.output_dir.join('full_logcat')
+ api.chromium_android.logcat_dump(output_logcat_file=logcat_file)
+ api.chromium_android.stack_tool_steps(logcat_file=logcat_file)
api.chromium_android.test_report()
« scripts/slave/recipe_modules/chromium_android/example.py ('K') | « scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json ('k') | scripts/slave/recipes/android_webview_aosp_perf.expected/basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698