scripts/slave/recipe_modules/chromium_android/example.py - Issue 1465343002: [Android] Add context manager to record logcat during step(s).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/example.py

Issue 1465343002: [Android] Add context manager to record logcat during step(s). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_android/example.py

diff --git a/scripts/slave/recipe_modules/chromium_android/example.py b/scripts/slave/recipe_modules/chromium_android/example.py

index ced6700e3a6c5031318f9ef6c39449ee1297cb49..7d768ed40350d5ba81d6c2752acee3913db31025 100644

--- a/scripts/slave/recipe_modules/chromium_android/example.py

+++ b/scripts/slave/recipe_modules/chromium_android/example.py

@@ -181,8 +181,10 @@ def RunSteps(api, buildername):

if not failure:

api.chromium_android.run_bisect_script(extra_src='test.py',

path_to_config='test.py')

- api.chromium_android.logcat_dump()

- api.chromium_android.stack_tool_steps()

+ logcat_file = api.chromium.output_dir.join('full_logcat')

+ api.chromium_android.logcat_dump(output_logcat_file=logcat_file)

luqui 2015/11/23 22:59:40 Heck as long as you're here you might as well use

mikecase (-- gone --) 2015/11/24 20:50:59 Added an example of using the logcat context manag

+ api.chromium_android.stack_tool_steps(logcat_file=logcat_file)

if config.get('coverage', False):

api.chromium_android.coverage_report()