Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1465303003: Generate separate navigation regions for 'super' and optional 'name'. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate separate navigation regions for 'super' and optional 'name'. Also support for navigation regions for RedirectingConstructorInvocation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/670db507079be11890937b79b39b3635e11f7ca3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 2 chunks +15 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years ago (2015-11-23 22:04:57 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-11-23 22:23:00 UTC) #2
scheglov
5 years ago (2015-11-23 22:27:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
670db507079be11890937b79b39b3635e11f7ca3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698