Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 1465303002: Propagate types for import/export closure before resolving. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Propagate types for import/export closure before resolving. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/aa9668b2646cca6c137bab8cc6770e9643452c54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -93 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 6 chunks +188 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +104 lines, -90 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/tasks.dot View 7 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-23 20:03:33 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-23 20:50:16 UTC) #2
scheglov
5 years, 1 month ago (2015-11-23 20:52:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa9668b2646cca6c137bab8cc6770e9643452c54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698