Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1465293002: Mojo C++ bindings: introduce public associated-interface-related types. (Closed)

Created:
5 years ago by yzshen1
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: introduce public associated-interface-related types. This includes: - AssociatedBinding - AssociatedGroup - AssociatedInterfacePtr - AssociatedInterfacePtrInfo - AssociatedInterfaceRequest BUG=546067 Committed: https://crrev.com/f2af33fc7b63697734bc5a1aeb772e67c9f85f9a Cr-Commit-Position: refs/heads/master@{#361365}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : fix GYP build #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1246 lines, -19 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/associated_binding.h View 1 2 3 4 1 chunk +138 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/associated_group.h View 1 2 3 4 1 chunk +91 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/associated_interface_ptr.h View 1 2 3 4 1 chunk +191 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr_info.h View 1 2 1 chunk +60 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_request.h View 1 2 1 chunk +62 lines, -6 lines 0 comments Download
A mojo/public/cpp/bindings/lib/associated_group.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/lib/associated_interface_ptr_internal.h View 1 2 1 chunk +132 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 1 2 1 chunk +451 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_associated_interfaces.mojom View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 2 3 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
5 years ago (2015-11-23 19:31:38 UTC) #2
sky
LGTM https://codereview.chromium.org/1465293002/diff/40001/mojo/public/cpp/bindings/associated_group.h File mojo/public/cpp/bindings/associated_group.h (right): https://codereview.chromium.org/1465293002/diff/40001/mojo/public/cpp/bindings/associated_group.h#newcode32 mojo/public/cpp/bindings/associated_group.h:32: enum AssociatedInterfaceConfig { WILL_PASS_PTR, WILL_PASS_REQUEST }; nit: enum's ...
5 years ago (2015-11-23 21:05:42 UTC) #3
yzshen1
Thanks Scott! https://codereview.chromium.org/1465293002/diff/40001/mojo/public/cpp/bindings/associated_group.h File mojo/public/cpp/bindings/associated_group.h (right): https://codereview.chromium.org/1465293002/diff/40001/mojo/public/cpp/bindings/associated_group.h#newcode32 mojo/public/cpp/bindings/associated_group.h:32: enum AssociatedInterfaceConfig { WILL_PASS_PTR, WILL_PASS_REQUEST }; On ...
5 years ago (2015-11-23 21:50:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465293002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465293002/80001
5 years ago (2015-11-23 21:52:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133083)
5 years ago (2015-11-23 23:46:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465293002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465293002/80001
5 years ago (2015-11-23 23:51:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133295)
5 years ago (2015-11-24 02:44:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465293002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465293002/80001
5 years ago (2015-11-24 16:15:38 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-11-24 16:43:25 UTC) #16
commit-bot: I haz the power
5 years ago (2015-11-24 16:44:17 UTC) #17
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/f2af33fc7b63697734bc5a1aeb772e67c9f85f9a
Cr-Commit-Position: refs/heads/master@{#361365}

Powered by Google App Engine
This is Rietveld 408576698