Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Issue 1465253002: Move OnKillFocus() from OmniboxEditController to WebOmniboxEditController (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move OnKillFocus() from OmniboxEditController to WebOmniboxEditController The only usage of this method is in iOS-specific code that knows that it's talking to a WebOmniboxEditController, so it's unnecessary to fork omnibox_edit_controller.h to expose this method. BUG=305330 Committed: https://crrev.com/454ee82190d895f9aaca0354f4141e64faea6f65 Cr-Commit-Position: refs/heads/master@{#361105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look. blundell: FYI
5 years ago (2015-11-23 15:15:15 UTC) #3
droger
lgtm
5 years ago (2015-11-23 15:19:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465253002/1
5 years ago (2015-11-23 15:20:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 15:29:54 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-23 15:31:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/454ee82190d895f9aaca0354f4141e64faea6f65
Cr-Commit-Position: refs/heads/master@{#361105}

Powered by Google App Engine
This is Rietveld 408576698