Limit the usage of SharedPersistent to ScriptValue only

Source/bindings/v8/ScriptValue.h

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef ScriptValue_h
 #define ScriptValue_h
 
-#include "bindings/v8/SharedPersistent.h"
-#include "wtf/PassRefPtr.h"
+#include "bindings/v8/ScopedPersistent.h"
+#include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 #include "wtf/text/WTFString.h"
 #include <v8.h>
 
 namespace WebCore {
 
 class JSONValue;
 class ScriptState;
 
+template <typename T>
+class SharedPersistent : public RefCounted<SharedPersistent<T> > {

[jochen (gone - plz use gerrit), 2014/01/24 12:19:21]

doesn't need to be a template anymore, does it?

you could also make it a private subclass of ScriptValue

[haraken, 2014/01/24 12:31:06]

Good point, fixed.

+    WTF_MAKE_NONCOPYABLE(SharedPersistent);
+public:
+    static PassRefPtr<SharedPersistent<T> > create(v8::Handle<T> value, v8::Isolate* isolate)
+    {
+        return adoptRef(new SharedPersistent<T>(value, isolate));
+    }
+
+    v8::Local<T> newLocal(v8::Isolate* isolate) const
+    {
+        return m_value.newLocal(isolate);
+    }
+
+    bool isEmpty() { return m_value.isEmpty(); }
+
+    bool operator==(const SharedPersistent<T>& other)
+    {
+        return m_value == other.m_value;
+    }
+
+private:
+    SharedPersistent(v8::Handle<T> value, v8::Isolate* isolate) : m_value(isolate, value) { }
+    ScopedPersistent<T> m_value;
+};
+
 class ScriptValue {
 public:
     ScriptValue()
         : m_isolate(0)
     { }
 
     virtual ~ScriptValue();
 
     ScriptValue(v8::Handle<v8::Value> value, v8::Isolate* isolate)
         : m_isolate(isolate)
@@ skipping 110 matching lines @@
     PassRefPtr<JSONValue> toJSONValue(ScriptState*) const;
 
 private:
     mutable v8::Isolate* m_isolate;
     RefPtr<SharedPersistent<v8::Value> > m_value;
 };
 
 } // namespace WebCore
 
 #endif // ScriptValue_h