Limit the usage of SharedPersistent to ScriptValue only

We've replaced SharedPersistent with ScopedPersistent or ScriptValue before, but a couple of SharedPersistents are remaining. So this CL replaces them.

Ideally we want to remove SharedPersistent though.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165751

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167313

[haraken, 2014-01-24 07:01:44]

PTAL

[jochen (gone - plz use gerrit), 2014-01-24 12:19:21]

https://codereview.chromium.org/146523002/diff/30001/Source/bindings/v8/Scrip...
File Source/bindings/v8/ScriptValue.h (right):

https://codereview.chromium.org/146523002/diff/30001/Source/bindings/v8/Scrip...
Source/bindings/v8/ScriptValue.h:46: class SharedPersistent : public
RefCounted<SharedPersistent<T> > {
doesn't need to be a template anymore, does it?

you could also make it a private subclass of ScriptValue

[haraken, 2014-01-24 12:31:05]

https://codereview.chromium.org/146523002/diff/30001/Source/bindings/v8/Scrip...
File Source/bindings/v8/ScriptValue.h (right):

https://codereview.chromium.org/146523002/diff/30001/Source/bindings/v8/Scrip...
Source/bindings/v8/ScriptValue.h:46: class SharedPersistent : public
RefCounted<SharedPersistent<T> > {
On 2014/01/24 12:19:21, jochen wrote:
> doesn't need to be a template anymore, does it?
> 
> you could also make it a private subclass of ScriptValue

Good point, fixed.

[jochen (gone - plz use gerrit), 2014-01-24 12:42:38]

lgtm

[commit-bot: I haz the power, 2014-01-24 12:43:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/146523002/80001

[commit-bot: I haz the power, 2014-01-24 14:09:26]

Change committed as 165751

[Alpha Left Google, 2014-01-25 00:35:31]

A revert of this CL has been created in
https://codereview.chromium.org/147333004/ by hclam@chromium.org.

The reason for reverting is: This change seems to be causing failures with
plugins on windows 7 build:

http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/...

The blame is 165731:165767 so this change looks most likely.
.

[haraken, 2014-02-18 05:53:17]

I'll reland this CL, since the CL is not the culprit. See
https://code.google.com/p/chromium/issues/detail?id=338122 for more details.

[haraken, 2014-02-18 05:53:29]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-18 05:53:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/146523002/80001

[commit-bot: I haz the power, 2014-02-18 07:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-18 07:06:13]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[haraken, 2014-02-18 07:11:13]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-18 07:11:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/146523002/80001

[commit-bot: I haz the power, 2014-02-18 08:46:06]

Change committed as 167313