gpu/command_buffer/service/feature_info.cc - Issue 1465223010: IsGL_REDSupportedOnFBOs: return true only if FBO is complete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 1465223010: IsGL_REDSupportedOnFBOs: return true only if FBO is complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/feature_info.cc

diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc

index fdc16a2598b86fdd2a6cc6d0fb0ee1f5a8b22b69..cd09bd0262bd40a3072ffada88f6b62d6bfa9574 100644

--- a/gpu/command_buffer/service/feature_info.cc

+++ b/gpu/command_buffer/service/feature_info.cc

@@ -268,7 +268,7 @@ bool IsGL_REDSupportedOnFBOs() {

glFramebufferTexture2DEXT(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D,

textureId, 0);

bool result =

- glCheckFramebufferStatusEXT(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_UNSUPPORTED;

+ glCheckFramebufferStatusEXT(GL_FRAMEBUFFER) == GL_FRAMEBUFFER_COMPLETE;

glDeleteFramebuffersEXT(1, &textureFBOID);

glDeleteTextures(1, &textureId);

« no previous file with comments | « no previous file | no next file » | no next file with comments »