Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1465223007: Fix promotion of JSFunctions with in-object properties. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix promotion of JSFunctions with in-object properties. BUG=v8:4572, chromium:561481 LOG=Y Committed: https://crrev.com/064bbccfa9aa17f1eb17bbf6e9b8ddd1e5f04e83 Cr-Commit-Position: refs/heads/master@{#32295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/heap/scavenger.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Igor Sheludko
PTAL
5 years ago (2015-11-25 16:40:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465223007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465223007/1
5 years ago (2015-11-25 16:40:03 UTC) #4
ulan
lgtm
5 years ago (2015-11-25 16:41:44 UTC) #5
Hannes Payer (out of office)
lgtm
5 years ago (2015-11-25 16:42:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465223007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465223007/1
5 years ago (2015-11-25 16:44:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 19:21:37 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-25 19:22:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/064bbccfa9aa17f1eb17bbf6e9b8ddd1e5f04e83
Cr-Commit-Position: refs/heads/master@{#32295}

Powered by Google App Engine
This is Rietveld 408576698