Issue 1465203003: EDK: Make ConnectionManagerTest not use base::MessageLoop/RunLoop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1465203003: EDK: Make ConnectionManagerTest not use base::MessageLoop/RunLoop. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Description

EDK: Make ConnectionManagerTest not use base::MessageLoop/RunLoop. Also add a QuitNow() method to mojo::platform::MessageLoop. I guess we do need it. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/12e4e72a049b3db57f2ea2074161fa3e20429948

Patch Set 1 #

Created: 5 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -47 lines)
M	mojo/edk/base_edk/platform_message_loop_impl.h	View	1 chunk	+1 line, -0 lines	0 comments
M	mojo/edk/base_edk/platform_message_loop_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments
M	mojo/edk/base_edk/platform_message_loop_impl_unittest.cc	View	2 chunks	+18 lines, -4 lines	0 comments
M	mojo/edk/platform/message_loop.h	View	1 chunk	+10 lines, -6 lines	0 comments
M	mojo/edk/system/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments
M	mojo/edk/system/connection_manager_unittest.cc	View	11 chunks	+38 lines, -37 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 1 month ago (2015-11-24 01:00:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
12e4e72a049b3db57f2ea2074161fa3e20429948 (presubmit successful).

Expand Messages | Collapse Messages