Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1465203002: [turbofan] Initial support for inline allocations of arrays. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for inline allocations of arrays. Add support for using inline allocations for arrays in lowering of JSCreateArray when target equals new.target. Currently we are only concerend with the straight-forward Array() and Array(length) cases, but at some point TurboFan should also be able to support the more complex initializing cases. R=mvstanton@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/e39050473fa0425f08eb22c5f28bf2320c72f5c5 Cr-Commit-Position: refs/heads/master@{#32191}

Patch Set 1 #

Patch Set 2 : Fix unbounded inlining. Reduce code duplication. Add proper code dependencies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -34 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 10 chunks +168 lines, -33 lines 0 comments Download
M src/type-cache.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-23 13:37:04 UTC) #1
Benedikt Meurer
Hey Michael, Here's an easy one to start with inlining the JSArray allocations in Turbofan. ...
5 years, 1 month ago (2015-11-23 13:37:46 UTC) #2
mvstanton
Pretty awesome! LGTM. Had to look up RelaxControls() though. :p
5 years, 1 month ago (2015-11-23 13:45:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465203002/1
5 years, 1 month ago (2015-11-23 13:47:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/12033)
5 years, 1 month ago (2015-11-23 13:54:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465203002/20001
5 years, 1 month ago (2015-11-24 06:14:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-24 07:02:29 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 07:03:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e39050473fa0425f08eb22c5f28bf2320c72f5c5
Cr-Commit-Position: refs/heads/master@{#32191}

Powered by Google App Engine
This is Rietveld 408576698