Source/core/platform/graphics/filters/FilterOperation.h - Issue 14652016: Implement filter primitive subregion for reference CSS filters. This required refactoring determin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/filters/FilterOperation.h

Issue 14652016: Implement filter primitive subregion for reference CSS filters. This required refactoring determin… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix test failures: ReferenceFilterOperation should ref the Filter which owns its FilterEffects Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/graphics/filters/FilterEffect.cpp ('k') | Source/core/platform/graphics/filters/FilterOperations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/graphics/filters/FilterOperation.h

diff --git a/Source/core/platform/graphics/filters/FilterOperation.h b/Source/core/platform/graphics/filters/FilterOperation.h

index 99329e693dc5a8a24b5bfe09bc11888b8282dd0d..f7d225341790789ceeb2dc970688a9f9134caedf 100644

--- a/Source/core/platform/graphics/filters/FilterOperation.h

+++ b/Source/core/platform/graphics/filters/FilterOperation.h

@@ -29,6 +29,7 @@

#include "core/platform/Length.h"

#include "core/platform/graphics/Color.h"

#include "core/platform/graphics/LayoutSize.h"

+#include "core/platform/graphics/filters/Filter.h"

#include "core/platform/graphics/filters/FilterEffect.h"

#include <wtf/OwnPtr.h>

#include <wtf/PassOwnPtr.h>

@@ -167,7 +168,7 @@ public:

#endif

FilterEffect* filterEffect() const { return m_filterEffect.get(); }

- void setFilterEffect(PassRefPtr<FilterEffect> filterEffect) { m_filterEffect = filterEffect; }

+ void setFilterEffect(PassRefPtr<FilterEffect> filterEffect, PassRefPtr<Filter> filter) { m_filterEffect = filterEffect; m_filter = filter; }

private:

@@ -192,6 +193,7 @@ private:

OwnPtr<CachedSVGDocumentReference> m_cachedSVGDocumentReference;

#endif

RefPtr<FilterEffect> m_filterEffect;

+ RefPtr<Filter> m_filter;

};

// GRAYSCALE, SEPIA, SATURATE and HUE_ROTATE are variations on a basic color matrix effect.