LayoutTests/css3/filters/effect-reference-subregion.html - Issue 14652016: Implement filter primitive subregion for reference CSS filters. This required refactoring determin…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/filters/effect-reference-subregion.html

Issue 14652016: Implement filter primitive subregion for reference CSS filters. This required refactoring determin… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <svg xmlns="http://www.w3.org/2000/svg" width="0" height="0" version="1.1">

	2 <defs>

	3 <filter id="f1">

	4 <feColorMatrix x="30" y="30" width="80" height="80" type="hueRotate" value s="180" id="colormatrix1"/>

	5 </filter>

	6 </defs>

	7 </svg>

	8 <img style="-webkit-filter: url(#f1); filter: url(#f1);" src="resources/referenc e.png"></img>
	Stephen Chennney 2013/05/02 16:53:55 There are also rules for how filterEffectRegion is There are also rules for how filterEffectRegion is "inherited" when applied to some filter effects but not others in the same filter, and also how it interacts with the filterRegion on the top level <filter> element. I wouldl recommend at least one test checking that the regions are correct in such cases. I believe we have SVG tests for this, but I don't know if they are sufficient to cover the CSS code paths.
OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/platform/graphics/filters/Filter.h » ('j') | Source/core/rendering/FilterEffectRenderer.cpp » ('J')