Fix error reporting when calling static methods and closures withh mismatched arguments.

runtime/lib/errors_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class Error {
   /* patch */ static String _objectToString(Object object) {
     return Object._toString(object);
   }
 }
 
 patch class NoSuchMethodError {
   // The compiler emits a call to _throwNew when it cannot resolve a static
   // method at compile time. The receiver is actually the literal class of the
   // unresolved method.
   static void _throwNew(Object receiver,
                         String memberName,
                         int invocation_type,
                         List arguments,
                         List argumentNames,
                         List existingArgumentNames) {
     int numNamedArguments = argumentNames == null ? 0 : argumentNames.length;
     int numPositionalArguments = arguments == null ? 0 : arguments.length;
     numPositionalArguments -= numNamedArguments;
     List positionalArguments;
     if (numPositionalArguments == 0) {
-      positionalArguments = [];
+      // Differ between no arguments specified and 0 arguments.

[regis, 2013/04/30 19:07:10]

When is _throwNew called with unspecified arguments?
I suppose that it is when we cannot resolve the method and do not bother
evaluating the arguments?
I think that the spec has changed in this regard, but not the implementation yet
(to be verified).
This case should never happen after we fix the implementation. Maybe a TODO
would be useful here.

[srdjan, 2013/04/30 21:46:52]

Adding comments: TODO(srdjan): This can currently occur for unresolvable static
methods. In that case, the arguments are evaluated but not passed to the
throwing stub (see EffectGraphVisitor::BuildThrowNoSuchMethodError and
Parser::ThrowNoSuchMethodError).

+      positionalArguments = argumentNames == null ? null : [];
     } else {
       positionalArguments = arguments.sublist(0, numPositionalArguments);
     }
     Map<String, dynamic> namedArguments = new Map<String, dynamic>();
     for (int i = 0; i < numNamedArguments; i++) {
       var arg_value = arguments[numPositionalArguments + i];
       namedArguments[argumentNames[i]] = arg_value;
     }
     throw new NoSuchMethodError._withType(receiver,
                                 memberName,
@@ skipping 35 matching lines @@
     var type_str =
         (const ["method", "getter", "setter", "getter or setter"])[type];
     var args_message = args_mismatch ? " with matching arguments" : "";
     var msg;
     switch (level) {
       case _InvocationMirror._DYNAMIC: {
         if (_receiver == null) {
           msg = "The null object does not have a $type_str '$_memberName'"
               "$args_message.";
         } else {
-          msg = "Class '${_receiver.runtimeType}' has no instance $type_str "
-              "'$_memberName'$args_message.";
+          if (_receiver is Function) {
+            msg = "Closure call with mismatched arguments: "
+                "function '$_memberName'";
+          } else {
+            msg = "Class '${_receiver.runtimeType}' has no instance $type_str "
+                "'$_memberName'$args_message.";
+          }
         }
         break;
       }
       case _InvocationMirror._STATIC: {
         msg = "No static $type_str '$_memberName' declared in class "
             "'$_receiver'.";
         break;
       }
       case _InvocationMirror._CONSTRUCTOR: {
         msg = "No constructor '$_memberName' declared in class '$_receiver'.";
         break;
       }
       case _InvocationMirror._TOP_LEVEL: {
-        msg = "No top-level $type_str '$_memberName' declared.";
+        msg = "No top-level $type_str '$_memberName'$args_message declared.";
         break;
       }
     }
     return "$msg\n\n";
   }
 
   /* patch */ String toString() {
     StringBuffer actual_buf = new StringBuffer();
     int i = 0;
-    if (_arguments != null) {
+    if (_arguments == null) {
+      // Actual arguments unknown.

[regis, 2013/04/30 19:07:10]

ditto

[srdjan, 2013/04/30 21:46:52]

Adding TODO(regis): Remove once arguments are passed for unresolvable static
methods.

+      actual_buf.write("...");

[regis, 2013/04/30 19:07:10]

Same question.

[srdjan, 2013/04/30 21:46:52]

Answered above.

+    } else {
       for (; i < _arguments.length; i++) {
         if (i > 0) {
           actual_buf.write(", ");
         }
         actual_buf.write(Error.safeToString(_arguments[i]));
       }
     }
     if (_namedArguments != null) {
       _namedArguments.forEach((String key, var value) {
         if (i > 0) {
@@ skipping 29 matching lines @@
       msg_buf.write(
           "NoSuchMethodError: incorrect number of arguments passed to "
           "method named '$_memberName'\n"
           "Receiver: $receiver_str\n"
           "Tried calling: $_memberName($actualParameters)\n"
           "Found: $_memberName($formalParameters)");
     }
     return msg_buf.toString();
   }
 }