Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1465193002: Record space shortage that prevented an object from fitting in one column. (Closed)

Created:
5 years ago by mstensho (USE GERRIT)
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record space shortage that prevented an object from fitting in one column. The breakability of the object doesn't matter here. The space shortage that prevented an object from fitting in one column may very well be the lowest space shortage that we'll ever find. So always record it, to avoid over-stretching columns. BUG=559133 R=leviw@chromium.org Committed: https://crrev.com/96d44249c0e83ac3512dff19904499334c01316d Cr-Commit-Position: refs/heads/master@{#361232}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html View 1 chunk +15 lines, -0 lines 2 comments Download
A + third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
mstensho (USE GERRIT)
5 years ago (2015-11-23 14:13:42 UTC) #1
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1465193002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html File third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html (right): https://codereview.chromium.org/1465193002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html#newcode1 third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html:1: <!DOCTYPE html> I found the original "test case" ...
5 years ago (2015-11-24 00:18:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465193002/1
5 years ago (2015-11-24 00:20:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 01:40:04 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/96d44249c0e83ac3512dff19904499334c01316d Cr-Commit-Position: refs/heads/master@{#361232}
5 years ago (2015-11-24 01:40:54 UTC) #6
mstensho (USE GERRIT)
https://codereview.chromium.org/1465193002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html File third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html (right): https://codereview.chromium.org/1465193002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html#newcode1 third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html:1: <!DOCTYPE html> On 2015/11/24 00:18:46, leviw wrote: > I ...
5 years ago (2015-11-24 06:37:27 UTC) #7
leviw_travelin_and_unemployed
5 years ago (2015-11-24 06:42:24 UTC) #8
Message was sent while issue was closed. 
On 2015/11/24 at 06:37:27, mstensho wrote:
>
https://codereview.chromium.org/1465193002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html
(right):
> 
>
https://codereview.chromium.org/1465193002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/multicol/balance-break-inside-avoid.html:1:
<!DOCTYPE html>
> On 2015/11/24 00:18:46, leviw wrote:
> > I found the original "test case" more amusing :p
> 
> Yeah... I had to stare at it for one whole day before I came up with this. :-P

The joys of working on the Web!

Hope you resisted doing all your Christmas shopping in one place :p

Powered by Google App Engine
This is Rietveld 408576698