Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1465153005: fix return type comment parsing for top-level generic function (Closed)

Created:
5 years ago by Jennifer Messerly
Modified:
5 years ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix return type comment parsing for top-level generic function R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/7feb6b7cb7c8b44046da463bba0b861817b31c8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years ago (2015-11-24 18:42:21 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-11-24 19:20:12 UTC) #3
Jennifer Messerly
5 years ago (2015-11-24 19:21:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7feb6b7cb7c8b44046da463bba0b861817b31c8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698