Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1465143004: Converts focusmanager from delegate to observer (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts focusmanager from delegate to observer I'm going to need more than one object to detect focus changes. BUG=548424 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/8db594182d61e2ade6b1fabebd8becd0f1c97f44 Cr-Commit-Position: refs/heads/master@{#361150}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -103 lines) Patch
M components/mus/gles2/gpu_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 5 chunks +8 lines, -8 lines 0 comments Download
M components/mus/ws/connection_manager.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M components/mus/ws/focus_controller.h View 2 chunks +17 lines, -12 lines 0 comments Download
M components/mus/ws/focus_controller.cc View 4 chunks +18 lines, -11 lines 0 comments Download
D components/mus/ws/focus_controller_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
A + components/mus/ws/focus_controller_observer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/mus/ws/focus_controller_unittest.cc View 5 chunks +33 lines, -27 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 5 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 1 month ago (2015-11-23 17:57:17 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-23 18:16:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465143004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465143004/20001
5 years, 1 month ago (2015-11-23 18:19:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 19:24:30 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 19:25:53 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8db594182d61e2ade6b1fabebd8becd0f1c97f44
Cr-Commit-Position: refs/heads/master@{#361150}

Powered by Google App Engine
This is Rietveld 408576698