only forbid unmanaged WiFi on AllowOnlyPolicyNetworksToConnect

only forbid unmanaged WiFi on AllowOnlyPolicyNetworksToConnect

BUG=208378
Committed: https://crrev.com/44e19583e4eae053625e25e8c33be0d3b01b672d
Cr-Commit-Position: refs/heads/master@{#361144}

[fqj, 2015-11-23 05:09:25]

fqj@chromium.org changed reviewers:
+ stevenjb@chromium.org

[fqj, 2015-11-23 05:09:25]

Add the missing network type check.
PTAL.

[stevenjb, 2015-11-23 18:03:24]

lgtm

https://codereview.chromium.org/1465133002/diff/1/chromeos/network/network_co...
File chromeos/network/network_connection_handler.cc (right):

https://codereview.chromium.org/1465133002/diff/1/chromeos/network/network_co...
chromeos/network/network_connection_handler.cc:554:
::onc::global_network_config::kAllowOnlyPolicyNetworksToConnect,
It's unfortunate that this is kAllowOnlyPolicyNetworksToConnect and not
kAllowOnlyPolicyWiFiNetworksToConnect. I notice that neither this nor
AllowOnlyPolicyNetworksToAutoconnect are documented in onc_spec.html. Can we
update that file and document what network types they affect (in a separate CL)?

[fqj, 2015-11-23 18:07:06]

https://codereview.chromium.org/1465133002/diff/1/chromeos/network/network_co...
File chromeos/network/network_connection_handler.cc (right):

https://codereview.chromium.org/1465133002/diff/1/chromeos/network/network_co...
chromeos/network/network_connection_handler.cc:554:
::onc::global_network_config::kAllowOnlyPolicyNetworksToConnect,
On 2015/11/23 18:03:24, stevenjb wrote:
> It's unfortunate that this is kAllowOnlyPolicyNetworksToConnect and not
> kAllowOnlyPolicyWiFiNetworksToConnect. I notice that neither this nor
> AllowOnlyPolicyNetworksToAutoconnect are documented in onc_spec.html. Can we
> update that file and document what network types they affect (in a separate
CL)?
> 

will do.
The naming, I just followed the autoconnect one, but after the server-side has
implemented(so changing name will be more work in other teams). I realized it
should only take effect to WiFi for the issue.

[fqj, 2015-11-23 18:07:11]

The CQ bit was checked by fqj@chromium.org

[commit-bot: I haz the power, 2015-11-23 18:07:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465133002/1

[commit-bot: I haz the power, 2015-11-23 18:20:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-23 18:21:51]

Patchset 1 (id:??) landed as
https://crrev.com/44e19583e4eae053625e25e8c33be0d3b01b672d
Cr-Commit-Position: refs/heads/master@{#361144}