Move webkit/compositor_bindings into webkit/renderer

Move webkit/compositor_bindings into webkit/renderer

The compositor bindings for WebKit should only be used in a render process or in
webkit_support for DumpRenderTree or webkit_unit_tests. It's never used in a
browser process. This moves the bindings code under webkit/renderer/ so we can
enforce this via DEPS rules.

The path is unfortunately a bit awkward. Once we drop DumpRenderTreeSupport and
figure out a way to deal with webkit_unit_tests, we can move the bindings into
content/renderer/gpu/ since they'll only be used by the content embedding.

BUG=239107
TBR=piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200350

[jamesr, 2013-05-10 19:24:55]

Antoine - mind taking a look since this is in anticipation of moving this code
into content/ ?  It's a bunch of file moves and build system goop, but there
shouldn't be any actual code changes.

[piman, 2013-05-10 19:33:45]

LGTM

[commit-bot: I haz the power, 2013-05-10 21:06:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14651027/17001

[commit-bot: I haz the power, 2013-05-10 23:11:55]

Retried try job too often on win7_aura for step(s) ash_unittests,
aura_unittests, browser_tests, compositor_unittests, content_browsertests,
content_unittests, interactive_ui_tests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-11 00:01:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14651027/17001

[commit-bot: I haz the power, 2013-05-11 03:39:53]

Retried try job too often on win_rel for step(s) chrome_frame_net_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-11 04:01:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14651027/17001

[commit-bot: I haz the power, 2013-05-11 07:04:28]

Retried try job too often on win_rel for step(s) chrome_frame_net_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-11 15:20:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14651027/17001

[commit-bot: I haz the power, 2013-05-11 18:45:17]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-11 21:40:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14651027/17001

[commit-bot: I haz the power, 2013-05-12 01:24:02]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-14 21:33:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/14651027/17001

[commit-bot: I haz the power, 2013-05-14 21:33:49]

Failed to apply patch for content/renderer/gpu/gpu_benchmarking_extension.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/gpu/gpu_benchmarking_extension.cc
  Hunk #1 FAILED at 17.
  1 out of 1 hunk FAILED -- saving rejects to file
content/renderer/gpu/gpu_benchmarking_extension.cc.rej

Patch:       content/renderer/gpu/gpu_benchmarking_extension.cc
Index: content/renderer/gpu/gpu_benchmarking_extension.cc
diff --git a/content/renderer/gpu/gpu_benchmarking_extension.cc
b/content/renderer/gpu/gpu_benchmarking_extension.cc
index
9d864deb957dffd90172ab5471194d3379ff66a7..08cecf2d97cc875bb57f446735cf09c1994244c0
100644
--- a/content/renderer/gpu/gpu_benchmarking_extension.cc
+++ b/content/renderer/gpu/gpu_benchmarking_extension.cc
@@ -17,15 +17,15 @@
 #include "content/renderer/gpu/render_widget_compositor.h"
 #include "content/renderer/render_view_impl.h"
 #include "content/renderer/rendering_benchmark.h"
-#include "third_party/skia/include/core/SkGraphics.h"
-#include "third_party/skia/include/core/SkPicture.h"
-#include "third_party/skia/include/core/SkStream.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include
"third_party/WebKit/Source/WebKit/chromium/public/WebViewBenchmarkSupport.h"
+#include "third_party/skia/include/core/SkGraphics.h"
+#include "third_party/skia/include/core/SkPicture.h"
+#include "third_party/skia/include/core/SkStream.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "v8/include/v8.h"
-#include "webkit/compositor_bindings/web_rendering_stats_impl.h"
+#include "webkit/renderer/compositor_bindings/web_rendering_stats_impl.h"
 
 using WebKit::WebCanvas;
 using WebKit::WebFrame;

[jamesr, 2013-05-15 20:46:05]

Rietveld refuses to accept updates to this patch (claims "Base files missing"). 
I have clean try runs submitted via 'git try' here:

http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...
http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...
http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...
http://build.chromium.org/p/tryserver.chromium/builders/linux_asan/builds/31051
http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/10...
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/52213
http://build.chromium.org/p/tryserver.chromium/builders/linux_aura/builds/40969
http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/127744
http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/128362
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/74003
http://build.chromium.org/p/tryserver.chromium/builders/win7_aura/builds/40273
http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/149081

gonna land by hand

[jamesr, 2013-05-15 21:18:57]

Committed patchset #15 manually as r200350 (presubmit successful).