Issue 14651022: Merge 199048 "Bluetooth: Parse the bluez.Error.Failed on pairing..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14651022: Merge 199048 "Bluetooth: Parse the bluez.Error.Failed on pairing..." (Closed)

Created:
7 years, 7 months ago by keybuk

Modified:
7 years, 7 months ago

Reviewers:
deymo

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 199048 "Bluetooth: Parse the bluez.Error.Failed on pairing..." > Bluetooth: Parse the bluez.Error.Failed on pairing error. > > The method org.bluez.Device1.Pair can return with different errors. > Among those, an org.bluez.Error.Failed: "Device or resource busy" is > a possible option. > > This patch parses that D-Bus error as an ERROR_FAILED. > > BUG=238479 > TEST=BluetoothExperimentalChromeOSTest.PairUnpairableDevice on device_unittests passed with the fix, and fails without it. > > Review URL: https://chromiumcodereview.appspot.com/15016004 TBR=deymo@chromium.org,rtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199512

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -0 lines)			Patch
M	chromeos/dbus/fake_bluetooth_device_client.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chromeos/dbus/fake_bluetooth_device_client.cc	View	4 chunks	+46 lines, -0 lines	0 comments	Download
M	device/bluetooth/bluetooth_device_experimental_chromeos.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	device/bluetooth/bluetooth_experimental_chromeos_unittest.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199512.

Expand Messages | Collapse Messages