chrome/browser/extensions/permissions_updater.cc - Issue 14651017: Move RuntimeData and related permissions out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/permissions_updater.cc

Issue 14651017: Move RuntimeData and related permissions out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_permissions

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/media_galleries/media_galleries_preferences.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/permissions_updater.cc

diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc

index f98d7029e9ce693afa9fa75d71690ce4fd2087d7..3e1ac8085fe4f0cd74bd0b141910bc6de473e826 100644

--- a/chrome/browser/extensions/permissions_updater.cc

+++ b/chrome/browser/extensions/permissions_updater.cc

@@ -17,6 +17,7 @@

#include "chrome/common/extensions/api/permissions.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_messages.h"

+#include "chrome/common/extensions/permissions/permissions_data.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_service.h"

@@ -24,7 +25,6 @@

using content::RenderProcessHost;

using extensions::permissions_api_helpers::PackPermissionSet;

-using extensions::PermissionSet;

namespace extensions {

@@ -90,7 +90,7 @@ void PermissionsUpdater::GrantActivePermissions(const Extension* extension) {

void PermissionsUpdater::UpdateActivePermissions(

const Extension* extension, const PermissionSet* permissions) {

GetExtensionPrefs()->SetActivePermissions(extension->id(), permissions);

- extension->SetActivePermissions(permissions);

+ PermissionsData::SetActivePermissions(extension, permissions);

}

void PermissionsUpdater::DispatchEvent(